git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Junio C Hamano <junkio@pobox.com>
Cc: Paul Mackerras <paulus@samba.org>, git@vger.kernel.org
Subject: Re: gitk from subdirectory
Date: Thu, 30 Aug 2007 22:08:26 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.0.999.0708302200160.25853@woody.linux-foundation.org> (raw)
In-Reply-To: <7vabs85ntg.fsf@gitster.siamese.dyndns.org>



On Thu, 30 Aug 2007, Junio C Hamano wrote:
> 
> I am wondering if this was intended behaviour change.  I think
> it makes sense to want an easy way to say "what changed stuff in
> the directory I am in?" because presumably you are there because
> you are interested in stuff in there.  But if you hard code "--"
> it is not easy to disable that and get the global log.

Hmm. My reaction to this would be that it was a mistake to have a 
difference between 

	git log --

and

	git log

and that we should instead fix this at the argument parsing level. 

And then anybody who depended on the old "--" behaviour can just add a "." 
at the end.

That way there are no special cases.

I realize that the "--" behaviour of git log was intentional, but seeing 
what it results in I think the intention was good, but stupid.

		Linus

  parent reply	other threads:[~2007-08-31  5:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-31  4:29 gitk from subdirectory Junio C Hamano
2007-08-31  4:33 ` Junio C Hamano
2007-08-31  5:08 ` Linus Torvalds [this message]
2007-08-31  5:29   ` Junio C Hamano
2007-08-31  5:32     ` Junio C Hamano
2007-08-31  5:45   ` Junio C Hamano
2007-08-31  5:51     ` Junio C Hamano
2007-08-31  7:38     ` Linus Torvalds
2007-08-31  7:40       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.0.999.0708302200160.25853@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@pobox.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).