From: Linus Torvalds <torvalds@linux-foundation.org>
To: Git Mailing List <git@vger.kernel.org>
Cc: Junio C Hamano <junkio@cox.net>
Subject: Re: Clean up "git log" format with DIFF_FORMAT_NO_OUTPUT
Date: Mon, 8 Oct 2007 13:55:07 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.999.0710081353290.4964@woody.linux-foundation.org> (raw)
In-Reply-To: <alpine.LFD.0.999.0710081342530.4964@woody.linux-foundation.org>
On Mon, 8 Oct 2007, Linus Torvalds wrote:
>
> This fixes an unnecessary empty line that we add to the log message when
> we generate diffs, but don't actually end up printing any due to having
> DIFF_FORMAT_NO_OUTPUT set.
Btw, this seems to break a few tests, where the test assumed the extra
newlines at the end of commands like "git show -s" (which also triggered
the extra unnecessary padding between commit text and the suppressed
diff).
I think the patch is correct, but the tests obviously would need fixing
before this patch should be applied.
Linus
next prev parent reply other threads:[~2007-10-08 20:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LFD.0.999.0710081337490.4964@woody.linux-foundation.org >
2007-10-08 20:42 ` Fix embarrassing "git log --follow" bug Linus Torvalds
2007-10-08 20:46 ` Clean up "git log" format with DIFF_FORMAT_NO_OUTPUT Linus Torvalds
2007-10-08 20:55 ` Linus Torvalds [this message]
2007-10-09 16:35 ` [take 2] " Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0710081353290.4964@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).