From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: Performance issue with excludes (was: Re: git-svn and submodules) Date: Mon, 15 Oct 2007 09:34:47 -0700 (PDT) Message-ID: References: <1192282153-26684-1-git-send-email-madcoder@debian.org> <20071014091855.GA17397@soma> <20071014095755.GF1198@artemis.corp> <20071014180815.GK1198@artemis.corp> <20071014210130.GA17675@soma> <20071014224959.GA17828@untitled> <05CAB148-56ED-4FF1-8AAB-4BA2A0B70C2C@lrde.epita.fr> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Cc: git list To: Benoit SIGOURE X-From: git-owner@vger.kernel.org Mon Oct 15 19:23:22 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1IhSus-0007DS-2s for gcvg-git-2@gmane.org; Mon, 15 Oct 2007 18:35:42 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763281AbXJOQfZ (ORCPT ); Mon, 15 Oct 2007 12:35:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761956AbXJOQfX (ORCPT ); Mon, 15 Oct 2007 12:35:23 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:39392 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759051AbXJOQfW (ORCPT ); Mon, 15 Oct 2007 12:35:22 -0400 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [207.189.120.55]) by smtp2.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id l9FGYlaD012199 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 15 Oct 2007 09:34:49 -0700 Received: from localhost (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id l9FGYltx013706; Mon, 15 Oct 2007 09:34:47 -0700 In-Reply-To: X-Spam-Status: No, hits=-2.677 required=5 tests=AWL,BAYES_00,TW_SV X-Spam-Checker-Version: SpamAssassin 3.1.0-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.53 on 207.189.120.14 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: On Mon, 15 Oct 2007, Benoit SIGOURE wrote: > > I re-used the test that was posted some time ago: I think your test is scrogged. You should add the ".gitignore" file *before* you do the "git add .". That's when it's going to hurt (since that's when you have new files you don't yet know about). But then it should hurt only for the "git add ." phase, not for anything else (unless we have the performance bug of doing the ignore matching even on files we know about). And more importantly, it should hurt only once (since afterwards, we'll know about the files and know not to ignore them). Linus