From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [REPLACEMENT PATCH 2/2] Add "--early-output" log flag for interactive GUI use Date: Sun, 4 Nov 2007 10:11:54 -0800 (PST) Message-ID: References: <18211.59478.188419.397886@cargo.ozlabs.ibm.com> <18212.13862.637991.30536@cargo.ozlabs.ibm.com> <18217.41899.54812.227152@cargo.ozlabs.ibm.com> <18218.63946.772767.179841@cargo.ozlabs.ibm.com> <18221.14113.498416.396006@cargo.ozlabs.ibm.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Cc: Marco Costalba , Junio C Hamano , Git Mailing List To: Paul Mackerras X-From: git-owner@vger.kernel.org Sun Nov 04 19:12:23 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1IojxL-0005VK-99 for gcvg-git-2@gmane.org; Sun, 04 Nov 2007 19:12:19 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753188AbXKDSMF (ORCPT ); Sun, 4 Nov 2007 13:12:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753495AbXKDSMD (ORCPT ); Sun, 4 Nov 2007 13:12:03 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:40338 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752949AbXKDSMC (ORCPT ); Sun, 4 Nov 2007 13:12:02 -0500 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [207.189.120.55]) by smtp2.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id lA4IBsB7016062 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 4 Nov 2007 10:11:56 -0800 Received: from localhost (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id lA4IBs9N010531; Sun, 4 Nov 2007 10:11:54 -0800 In-Reply-To: X-Spam-Status: No, hits=-3.235 required=5 tests=AWL,BAYES_00,OSDL_HEADER_SUBJECT_BRACKETED X-Spam-Checker-Version: SpamAssassin 3.1.0-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.53 on 207.189.120.14 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: On Sat, 3 Nov 2007, Linus Torvalds wrote: > > > > How hard would it be to put the total number of commits on that "Final > > output" line? That would be useful for me. > > Not hard. I think we basically have it anyway. Actually, I take that back. It's hard. Not because we don't have the commits, but because while we do the top-level shape pruning in the eearly stages, we do *not* do the final path-limiting until we actually output the commits. Which actually makes "--early-output" right now do some rather odd things when you use a path limiter: we don't do the "rewrite_parents()" thing until later, so the early output will have done the first level of history simplification, but it won't have made history *dense* yet. I'm looking at it now, I'll have to think about this a bit more. It might be trivial to fix, but this thing has real potential for being subtle. Linus