From: Nicolas Pitre <nico@cam.org>
To: Jeff King <peff@peff.net>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH] Change 'Deltifying objects' to 'Delta compressing objects'
Date: Thu, 18 Oct 2007 23:01:02 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.0.9999.0710182251110.19446@xanadu.home> (raw)
In-Reply-To: <20071019023425.GB8298@coredump.intra.peff.net>
On Thu, 18 Oct 2007, Jeff King wrote:
> On a similar note, some complaints with progress meters, even after
> recent patches:
> - When fetching, one progress meter says "Indexing" which, while
> technically true, is almost certainly blocking on "Downloading". In
> fact, it is not clear from the existing messages exactly _when_ we
> are downloading, and when we are just computing, which is something
> I think a user might want to know. Objections to changing this
> (though perhaps index-pack will need to be told when it is
> downloading and when it is just indexing)? Objections to a
> throughput indicator?
I have some WIP for that.
> - Running git-gc, we now get something like:
> Counting objects: 62317, done.
> Deltifying objects: 100% (18042/18042), done.
> Writing objects: 100% (62317/62317), done.
> Total 62317 (delta 43861), reused 61404 (delta 43036)
> Pack pack-32f8ac40c1a5ec146e45c657cb16f53fdd354095 created.
> Removing unused objects 100%...
> Done.
> Can we get rid of total statistics (I think this is useful for some
> power users, but perhaps there should be a verbosity level), the
> name of the pack file (same deal), and the totally useless "Done."?
Agreed for the pack name. Certainly no one cares.
Maybe the "Removing unused objects" should use the common progress
infrastructure? It could even use the delayed interface, just like when
checking out files, so no progress at all is displayed when that
operation completes within a certain delay. And the removal of unused
objects is usually quick.
But I like the statistics. They might be pretty handy to diagnoze
performance issues on remote servers for example.
Nicolas
next prev parent reply other threads:[~2007-10-19 3:01 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 0:45 [PATCH] Change 'Deltifying objects' to 'Delta compressing objects' Shawn O. Pearce
2007-10-19 2:12 ` Jeff King
2007-10-19 2:19 ` Sam Vilain
2007-10-19 2:24 ` David Symonds
2007-10-19 2:34 ` Shawn O. Pearce
2007-10-19 3:02 ` Nicolas Pitre
2007-10-19 2:36 ` Jeff King
2007-10-19 2:55 ` Sam Vilain
2007-10-19 2:25 ` Jeff King
2007-10-19 2:21 ` Shawn O. Pearce
2007-10-19 2:34 ` Jeff King
2007-10-19 2:47 ` Shawn O. Pearce
2007-10-19 3:01 ` Nicolas Pitre [this message]
2007-10-19 3:07 ` Jeff King
2007-10-19 3:24 ` Nicolas Pitre
2007-10-19 3:32 ` Jeff King
2007-10-19 3:50 ` Nicolas Pitre
2007-10-19 3:56 ` Jeff King
2007-10-19 4:21 ` Linus Torvalds
2007-10-19 4:29 ` Jeff King
2007-10-19 11:58 ` Nicolas Pitre
2007-10-19 19:00 ` Linus Torvalds
2007-10-19 21:57 ` Linus Torvalds
2007-10-19 5:09 ` Shawn O. Pearce
2007-10-19 3:33 ` Shawn O. Pearce
2007-10-19 5:03 ` [PATCH] Stop displaying "Pack pack-$ID created." during git-gc Shawn O. Pearce
2007-10-19 2:49 ` [PATCH] Change 'Deltifying objects' to 'Delta compressing objects' Nicolas Pitre
2007-10-19 3:17 ` Shawn O. Pearce
2007-10-19 3:38 ` Nicolas Pitre
2007-10-19 3:41 ` Jeff King
2007-10-19 3:45 ` Shawn O. Pearce
2007-10-19 4:02 ` Nicolas Pitre
2007-10-19 11:44 ` Wincent Colaiuta
2007-10-19 2:45 ` Nicolas Pitre
2007-10-19 2:59 ` Jeff King
2007-10-19 3:11 ` Nicolas Pitre
2007-10-19 3:15 ` Jeff King
2007-10-19 3:27 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.9999.0710182251110.19446@xanadu.home \
--to=nico@cam.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).