From: Nicolas Pitre <nico@cam.org>
To: Jeff King <peff@peff.net>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH] Change 'Deltifying objects' to 'Delta compressing objects'
Date: Thu, 18 Oct 2007 23:11:26 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.0.9999.0710182306300.19446@xanadu.home> (raw)
In-Reply-To: <20071019025913.GA9227@coredump.intra.peff.net>
On Thu, 18 Oct 2007, Jeff King wrote:
> On Thu, Oct 18, 2007 at 10:45:31PM -0400, Nicolas Pitre wrote:
>
> > Yet that progress display isn't solely about "delta compressing". It
> > also includes the search for best object match in order to keep the
> > smallest delta possible.
>
> In fact, isn't that progress meter _solely_ about finding the best
> matches? The actual deltification (that is, the creation of the deltas
> and writing of them to the packfile happens during the writing phase --
> unless, of course, we've cached the deltas during the search phase).
Well, to find which combination is the smallest you actually have to
create deltas.
> Perhaps one of:
>
> Finding deltas
> Finding delta candidates
> Matching objects
>
> or something similar (though I don't especially like any of them, I
> think you get the idea).
I think we might sidestep the issue entirely by remaining somewhat vague
and simply saying "compressing objects" for that phase. This is the
part responsible for the reduction of a Git repository from 3GB down to
200MB anyway.
Nicolas
next prev parent reply other threads:[~2007-10-19 3:11 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 0:45 [PATCH] Change 'Deltifying objects' to 'Delta compressing objects' Shawn O. Pearce
2007-10-19 2:12 ` Jeff King
2007-10-19 2:19 ` Sam Vilain
2007-10-19 2:24 ` David Symonds
2007-10-19 2:34 ` Shawn O. Pearce
2007-10-19 3:02 ` Nicolas Pitre
2007-10-19 2:36 ` Jeff King
2007-10-19 2:55 ` Sam Vilain
2007-10-19 2:25 ` Jeff King
2007-10-19 2:21 ` Shawn O. Pearce
2007-10-19 2:34 ` Jeff King
2007-10-19 2:47 ` Shawn O. Pearce
2007-10-19 3:01 ` Nicolas Pitre
2007-10-19 3:07 ` Jeff King
2007-10-19 3:24 ` Nicolas Pitre
2007-10-19 3:32 ` Jeff King
2007-10-19 3:50 ` Nicolas Pitre
2007-10-19 3:56 ` Jeff King
2007-10-19 4:21 ` Linus Torvalds
2007-10-19 4:29 ` Jeff King
2007-10-19 11:58 ` Nicolas Pitre
2007-10-19 19:00 ` Linus Torvalds
2007-10-19 21:57 ` Linus Torvalds
2007-10-19 5:09 ` Shawn O. Pearce
2007-10-19 3:33 ` Shawn O. Pearce
2007-10-19 5:03 ` [PATCH] Stop displaying "Pack pack-$ID created." during git-gc Shawn O. Pearce
2007-10-19 2:49 ` [PATCH] Change 'Deltifying objects' to 'Delta compressing objects' Nicolas Pitre
2007-10-19 3:17 ` Shawn O. Pearce
2007-10-19 3:38 ` Nicolas Pitre
2007-10-19 3:41 ` Jeff King
2007-10-19 3:45 ` Shawn O. Pearce
2007-10-19 4:02 ` Nicolas Pitre
2007-10-19 11:44 ` Wincent Colaiuta
2007-10-19 2:45 ` Nicolas Pitre
2007-10-19 2:59 ` Jeff King
2007-10-19 3:11 ` Nicolas Pitre [this message]
2007-10-19 3:15 ` Jeff King
2007-10-19 3:27 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.9999.0710182306300.19446@xanadu.home \
--to=nico@cam.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).