From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jakub Narebski <jnareb@gmail.com>, Nicolas Pitre <nico@cam.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: Some git performance measurements..
Date: Thu, 29 Nov 2007 18:54:01 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.0.9999.0711291836230.8458@woody.linux-foundation.org> (raw)
In-Reply-To: <alpine.LFD.0.9999.0711291812530.8458@woody.linux-foundation.org>
On Thu, 29 Nov 2007, Linus Torvalds wrote:
>
> Something like the appended (untested!
Ok, tested now. It does seem to work. The page fault trace for the
pack-file shows that we now get basically perfect IO patterns for my "git
checkout" testcase, and while I'm not sure that's necessarily a test-case
that really deserves this kind of attention, it's certainly potentially
interesting.
To check the performance impact of this, though, you'd need to pack the
same repository two different ways - with this kind of sorting change and
without - and then test different cold-cache timings for things like "git
blame" etc that might care.
The timing of the commands itself could be done with either a pre-change
or post-change version of git, it's only the resulting order in the
pack-file that matters.
My very unscientific tests says that "git read-tree" is speed up by the
change (from 5.2s to 3.3s, so it's quite noticeable), but "git blame"
slows down (from 8.7s to 12.9s, so that's quite noticeable too). But as
Jakub pointed out, the cold-cache numbers do fluctuate a lot, and while
they were reasonably stable over runs, the "git blame" numbers in
particular probably depend a fair amount on whether the file is commonly
changed or not.
Anybody interested in trying to do something more scientific?
Linus
next prev parent reply other threads:[~2007-11-30 2:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-29 2:49 Some git performance measurements Linus Torvalds
2007-11-29 3:14 ` Linus Torvalds
2007-11-29 3:59 ` Nicolas Pitre
2007-11-29 4:32 ` Linus Torvalds
2007-11-29 17:25 ` Nicolas Pitre
2007-11-29 17:48 ` Linus Torvalds
2007-11-29 18:52 ` Nicolas Pitre
2007-11-30 5:00 ` Junio C Hamano
2007-11-30 6:03 ` Linus Torvalds
2007-11-30 0:54 ` Jakub Narebski
2007-11-30 2:21 ` Linus Torvalds
2007-11-30 2:39 ` Jakub Narebski
2007-11-30 2:40 ` Nicolas Pitre
2007-11-30 6:11 ` Steffen Prohaska
2007-12-07 13:35 ` Mike Ralphson
2007-12-07 13:49 ` Johannes Schindelin
2007-12-07 16:07 ` Linus Torvalds
2007-12-07 16:09 ` Mike Ralphson
2007-12-07 18:37 ` Johannes Schindelin
2007-12-07 19:15 ` Mike Ralphson
2007-12-08 11:05 ` Johannes Schindelin
2007-12-08 23:04 ` Brian Downing
2007-11-30 2:54 ` Linus Torvalds [this message]
2007-12-05 1:04 ` Federico Mena Quintero
2007-12-01 11:36 ` Joachim B Haga
2007-12-01 17:19 ` Linus Torvalds
2007-11-29 5:17 ` Junio C Hamano
2007-11-29 10:17 ` [PATCH] per-directory-exclude: lazily read .gitignore files Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.9999.0711291836230.8458@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).