Re: [PATCH] Move all dashed form git commands to libexecdir

[Nicolas Pitre <nico@cam.org>]

On Thu, 29 Nov 2007, Nguyen Thai Ngoc Duy wrote:

> On Nov 29, 2007 6:14 AM, Junio C Hamano <gitster@pobox.com> wrote:
> >
> > "Nguyen Thai Ngoc Duy" <pclouds@gmail.com> writes:
> >
> > > On Nov 28, 2007 8:13 AM, Junio C Hamano <gitster@pobox.com> wrote:
> > >> In case somebody is thinking about 36e5e70e0f40 (Start deprecating
> > >> "git-command" in favor of "git command"), that is a somewhat different
> > >> issue.  What Linus suggested is not installing git-foo link for built-in
> > >> commands _anywhere_ on the filesystem.  Not just "out of user's PATH".
> > >> That is not deprecating dash form but removing the support for it.  We
> > >> need to give ample time for users to adjust to such a change.
> > >
> > > A little note on this one. I've been using git without builtin links
> > > for a while with my git-box port. There are still some builtin fixups
> > > needed. And because execv_git_cmd() always uses dash form, so it's
> > > impossible to use vanilla git without builtin links.
> >
> > Thanks for a heads up.
> >
> > Would people agree with a rough roadmap like this?
> >
> >  - v1.5.4 will ship with gitexecdir=$(bindir) in Makefile.  But the
> >    release notes for the version will warn users that:
> >
> >    (1) using git-foo from the command line, and
> >
> >    (2) using git-foo from your scripts without first prepending the
> >        return value of "git --exec-path" to the PATH
> >
> >    is now officially deprecated (it has been deprecated for a long time
> >    since January 2006, v1.2.0~149) and upcoming v1.5.5 will ship with
> >    the default configuration that does not install git-foo form in
> >    user's PATH.
> >
> >  - Post v1.5.4, start cooking gitexecdir=$(libexecdir)/git-core, aiming
> >    for inclusion in v1.5.5, perhaps in Mar-Feb 2008 timeframe.
> >
> >  - The release notes for v1.5.5 will warn users that git-foo will be
> >    removed in v1.6.0 for many commands and it will be merely an accident
> >    if some of them still work.
> >
> >  - Post v1.5.5, start cooking the change that does not install hardlinks
> >    for built-in commands, aiming for inclusion in v1.6.0, by the end of
> >    2008.
> 
> There won't be a stage when only porcelain git-foos are in $(bindir)?
> I could stop working on the relevant patch then.

Well, I personally found your effort really nice.  I think Junio is 
overly cautious in this case, and I would prefer to see the number of 
git commands in the default path drop rather sooner than later.


Nicolas