From: Nicolas Pitre <nico@cam.org>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: Performance problem, long run of identical hashes
Date: Mon, 10 Dec 2007 10:45:49 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.0.99999.0712101037270.555@xanadu.home> (raw)
In-Reply-To: <9e4733910712100707i66e185bofe22805b8e0ba4d8@mail.gmail.com>
On Mon, 10 Dec 2007, Jon Smirl wrote:
> Running oprofile during my gcc repack shows this loop as the hottest
> place in the code by far.
Well, that is kind of expected.
> I added some debug printfs which show that I
> have a 100,000+ run of identical hash entries. Processing the 100,000
> entries also causes RAM consumption to explode.
That is impossible. If you look at the code where those hash entries
are created in create_delta_index(), you'll notice a hard limit of
HASH_LIMIT (currently 64) is imposed on the number of identical hash
entries.
Nicolas
next prev parent reply other threads:[~2007-12-10 15:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-10 15:07 Performance problem, long run of identical hashes Jon Smirl
2007-12-10 15:45 ` Nicolas Pitre [this message]
2007-12-10 16:14 ` David Kastrup
2007-12-10 16:20 ` Jon Smirl
2007-12-10 16:30 ` Nicolas Pitre
2007-12-10 19:39 ` David Kastrup
2007-12-10 20:11 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.99999.0712101037270.555@xanadu.home \
--to=nico@cam.org \
--cc=git@vger.kernel.org \
--cc=jonsmirl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).