Git development
 help / color / mirror / Atom feed
From: Nicolas Pitre <nico@cam.org>
To: David Tweed <david.tweed@gmail.com>
Cc: gi mailing list <git@vger.kernel.org>
Subject: Re: [RFC,PATCH] Make git prune remove temporary packs that look like write failures
Date: Mon, 04 Feb 2008 09:52:38 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.1.00.0802040945370.2732@xanadu.home> (raw)
In-Reply-To: <e1dab3980802040610s27a54a9due3b42db5f59c0cd5@mail.gmail.com>

On Mon, 4 Feb 2008, David Tweed wrote:

> In principle this is a really trivial patch, but I'm being cautious because I
> don't like the fact that I don't know (and AFAICS can't reliably check) that
> the files being deleting are definitely dead. An alternative would
> be to make prune just print out that the suspicious packs are
> there and let the user delete them manually. (My itch is that once
> a write-failure pack gets created, nothing in git operations tells the
> user that a generally multimegabyte file hidden in .git occupying space.)

The lifelessness of a temporary pack is the same as for loose objects, 
hence the same rule should apply in both cases.  Just asking the user to 
delete them manually isn't too nice either.  A prune operation is 
already said to be dangerous and should be performed only when no other 
activities are occurring in the same repository.  That should cover the 
case of dead temporary pack files just as well.


Nicolas

  reply	other threads:[~2008-02-04 14:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-04 14:10 [RFC,PATCH] Make git prune remove temporary packs that look like write failures David Tweed
2008-02-04 14:52 ` Nicolas Pitre [this message]
2008-02-04 15:16 ` Johannes Schindelin
2008-02-04 15:24   ` David Tweed
2008-02-04 17:21     ` Johannes Schindelin
2008-02-04 17:39       ` David Tweed
2008-02-04 17:42         ` David Tweed
2008-02-04 17:47         ` Nicolas Pitre
2008-02-04 17:54           ` David Tweed
2008-02-04 16:06   ` Nicolas Pitre
2008-02-04 16:33     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.00.0802040945370.2732@xanadu.home \
    --to=nico@cam.org \
    --cc=david.tweed@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox