From: Nicolas Pitre <nico@cam.org>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Martin Koegler <mkoegler@auto.tuwien.ac.at>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH 1/4] add generic, type aware object chain walker
Date: Mon, 25 Feb 2008 12:35:31 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.1.00.0802251233020.3167@xanadu.home> (raw)
In-Reply-To: <20080225081206.GO8410@spearce.org>
On Mon, 25 Feb 2008, Shawn O. Pearce wrote:
> Martin Koegler <mkoegler@auto.tuwien.ac.at> wrote:
> > On Mon, Feb 25, 2008 at 12:02:15AM -0800, Junio C Hamano wrote:
> > > mkoegler@auto.tuwien.ac.at (Martin Koegler) writes:
> > >
> > > > What about
> > > > #define OBJ_BAD -2
> > >
> > > You mean "#define OBJ_ANY -2"?
> >
> > Yes.
> >
> > Should it go into cache.h or should it stay in fsck.h?
>
> I'd rather see this declared at the end of enum object_type, as
> essentially OBJ_MAX-1. But Nico may have a different opinion.
Why not alias OBJ_ANY to OBJ_NONE instead?
Nicolas
next prev parent reply other threads:[~2008-02-25 17:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-24 14:43 [PATCH 1/4] add generic, type aware object chain walker Martin Koegler
2008-02-24 14:43 ` [PATCH 2/4] builtin-fsck: move away from object-refs Martin Koegler
2008-02-24 14:43 ` [PATCH 3/4] Remove unused object-ref code Martin Koegler
2008-02-24 14:43 ` [PATCH 4/4] builtin-fsck: reports missing parent commits Martin Koegler
2008-02-25 3:04 ` [PATCH 1/4] add generic, type aware object chain walker Shawn O. Pearce
2008-02-25 7:26 ` Martin Koegler
2008-02-25 7:37 ` Junio C Hamano
2008-02-25 7:52 ` Martin Koegler
2008-02-25 8:02 ` Junio C Hamano
2008-02-25 8:06 ` Martin Koegler
2008-02-25 8:12 ` Shawn O. Pearce
2008-02-25 17:35 ` Nicolas Pitre [this message]
2008-02-25 8:04 ` Shawn O. Pearce
2008-02-25 17:49 ` Nicolas Pitre
2008-02-25 3:08 ` Junio C Hamano
2008-02-25 7:46 ` Martin Koegler
2008-02-25 7:59 ` Junio C Hamano
2008-02-25 8:21 ` Martin Koegler
2008-02-25 8:10 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.00.0802251233020.3167@xanadu.home \
--to=nico@cam.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mkoegler@auto.tuwien.ac.at \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).