From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: Why repository grows after "git gc"? / Purpose of *.keep files? Date: Wed, 14 May 2008 13:19:08 -0700 (PDT) Message-ID: References: <20080512122900.GA13050@mithlond.arda.local> <20080512155243.GA3592@mithlond.arda.local> <20080512184334.GB5160@mithlond.arda.local> <20080512190946.GC5160@mithlond.arda.local> <20080512202414.GA8620@mithlond.arda.local> <20080512210304.GA17352@glandium.org> <20080512210807.GA22221@glandium.org> <20080513001252.GB29038@spearce.org> <7vy76dperf.fsf@gitster.siamese.dyndns.org> <18474.44155.823000.368851@lapjr.intranet.kiel.bmiag.de> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Junio C Hamano , Nicolas Pitre , "Shawn O. Pearce" , Mike Hommey , Teemu Likonen , Johannes Schindelin , git@vger.kernel.org To: Juergen Ruehle X-From: git-owner@vger.kernel.org Wed May 14 22:23:46 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1JwNVp-0004rV-78 for gcvg-git-2@gmane.org; Wed, 14 May 2008 22:23:45 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750814AbYENUWx (ORCPT ); Wed, 14 May 2008 16:22:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750810AbYENUWw (ORCPT ); Wed, 14 May 2008 16:22:52 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:39969 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803AbYENUWw (ORCPT ); Wed, 14 May 2008 16:22:52 -0400 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id m4EKJ9xB015254 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 14 May 2008 13:19:11 -0700 Received: from localhost (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id m4EKJ8iQ018902; Wed, 14 May 2008 13:19:08 -0700 In-Reply-To: User-Agent: Alpine 1.10 (LFD 962 2008-03-14) X-Spam-Status: No, hits=-3.42 required=5 tests=AWL,BAYES_00 X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Wed, 14 May 2008, Linus Torvalds wrote: > > I think this patch is correct, but I wonder why you removed the pruning > from revision.c? In fact, it might be a good idea to not just keep it in revision.c, but move it up a bit, so that a commit that is packed and should be ignored won't even have its parents put on the list (which means that we not only ignore the trees in that commit, but also all parents). Of course, the more aggressively we prune, the more we end up having to depend on the fact that a commit that is in a pack that is marked "keep" must *always* have everything that leads to it in that pack or others also marked "keep". We effectively have that already (because we've always pruned away the commits early), but it's a thing to keep in mind whenever we prune even more aggressively. Linus