From: Nicolas Pitre <nico@cam.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Denis Bueno <dbueno@gmail.com>, Git Mailing List <git@vger.kernel.org>
Subject: Re: Recovering from repository corruption
Date: Tue, 10 Jun 2008 21:47:38 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0806102143080.23110@xanadu.home> (raw)
In-Reply-To: <alpine.LFD.1.10.0806101836510.3101@woody.linux-foundation.org>
On Tue, 10 Jun 2008, Linus Torvalds wrote:
>
>
> On Tue, 10 Jun 2008, Nicolas Pitre wrote:
> >
> > I think this only gives a false sense of security with a huge
> > performance cost. If the machine crashes at the right moment, the
> > object will still be half written/fsync'd and you'll be in the same
> > situation again.
>
> No you wouldn't.
>
> We do the write and the fsync() of the write to a _temporary_ filename. We
> do the rename _after_ the fsync.
Ah, true. That part somehow evaded my mind.
Nicolas
next prev parent reply other threads:[~2008-06-11 1:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-10 17:26 Recovering from repository corruption Denis Bueno
2008-06-10 17:55 ` Jakub Narebski
2008-06-10 19:38 ` Denis Bueno
2008-06-10 19:59 ` Jakub Narebski
2008-06-10 20:03 ` Denis Bueno
2008-06-10 20:14 ` Jakub Narebski
2008-06-10 20:35 ` Denis Bueno
2008-06-10 20:23 ` Linus Torvalds
2008-06-10 20:28 ` Denis Bueno
2008-06-10 21:09 ` Linus Torvalds
2008-06-10 21:22 ` Denis Bueno
2008-06-10 21:48 ` Linus Torvalds
2008-06-10 22:09 ` Denis Bueno
2008-06-10 22:25 ` Tarmigan
2008-06-10 22:41 ` Denis Bueno
2008-06-10 22:45 ` Linus Torvalds
2008-06-10 23:00 ` Linus Torvalds
2008-06-11 0:43 ` Nicolas Pitre
2008-06-11 1:39 ` Linus Torvalds
2008-06-11 1:47 ` Nicolas Pitre [this message]
2008-06-10 21:27 ` Denis Bueno
2008-06-10 22:52 ` Junio C Hamano
2008-06-11 23:21 ` To graft or not to graft... (Re: Recovering from repository corruption) Stephen R. van den Berg
2008-06-11 23:34 ` Jakub Narebski
2008-06-11 23:39 ` Linus Torvalds
2008-06-12 7:14 ` Johan Herland
2008-06-12 7:47 ` Jeff King
2008-06-12 10:21 ` Johan Herland
2008-06-12 12:20 ` Stephen R. van den Berg
2008-06-10 19:40 ` Recovering from repository corruption Nicolas Pitre
2008-06-10 19:42 ` Denis Bueno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0806102143080.23110@xanadu.home \
--to=nico@cam.org \
--cc=dbueno@gmail.com \
--cc=git@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).