From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Alexander N. Gavrilov" <angavrilov@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [RFC PATCH] Fix quadratic performance in rewrite_one.
Date: Sat, 12 Jul 2008 15:55:27 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0807121550320.2959@woody.linux-foundation.org> (raw)
In-Reply-To: <200807122200.58187.angavrilov@gmail.com>
On Sat, 12 Jul 2008, Alexander N. Gavrilov wrote:
>
> Parent commits are usually older than their children. Thus,
> on each iteration of the loop in rewrite_one, add_parents_to_list
> traverses all commits previously processed by the loop.
> It performs very poorly in case of very long rewrite chains.
Good call, but you don't seem to invalidate the cache when we remove
things from the list.
The top of the limit_list() loop does that "get top entry from list, an
free it", and I'm not seeing you invalidating the cache if that entry that
just got free'd happened to be the cache entry?
Or did I miss some reason why that couldn't happen?
Linus
next prev parent reply other threads:[~2008-07-12 22:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-12 18:00 [RFC PATCH] Fix quadratic performance in rewrite_one Alexander N. Gavrilov
2008-07-12 22:55 ` Linus Torvalds [this message]
2008-07-13 0:37 ` Alexander Gavrilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0807121550320.2959@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=angavrilov@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).