From: Linus Torvalds <torvalds@linux-foundation.org>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Tim Harper <timcharper@gmail.com>, git@vger.kernel.org
Subject: Re: Bizarre missing changes (git bug?)
Date: Tue, 29 Jul 2008 08:50:02 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0807290838360.3334@nehalem.linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0807291235350.6791@localhost.localdomain>
On Tue, 29 Jul 2008, Roman Zippel wrote:
>
> I'm not dismissing it, but your focus is on how to get this result.
No, you misunderstand.
My focus is really on one single thing:
- performance
with a smaller focus on the fact that I simply don't see how it's
_possible_ to do better than our current all-or-nothing approach of
simplification (eg either extreme simplification or none at all: nothing
or --full-history).
So here's my challenge again, which you seem to have TOTALLY MISSED.
Make this be fast:
time sh -c "git log <filename> | head"
nothing else matters. If you can make that one be fast, I'm happy.
And that "| head" is really very fundamentally important. The important
thing from a performance standpoint is not how long the _whole_ "log"
takes. The important thing is how fast it _feels_, and that is directly
tied to how fast it starts outputting the data.
Put another way: I _know_ how to simplify things. Trust me, Roman. That's
not the problem. But doing it incrementally is really really hard, to the
point that I actually believe that it is impossible to do.
And doing it after-the-fact is simply not interesting. We could trivially
(well, _fairly_ trivially) do it when we do the topology sort. But I have
long long tried to teach people _not_ to do the topo sort inside the core
git machinery, exactly because it is a horrid thing from an interactivity
standpoint.
In fact, you can see what I'm talking about by trying --topo-order in the
above timing test.
Really. Just _try_ it. And if you still don't understand what I'm talking
about, I don't know what to say.
> > And quite frankly, I've seen that behaviour from you before, when it comes
> > to other things.
>
> What exact behaviour is that? That I dare to disagree with you?
No. The fact that you like arguing _pointlessly_, and just being abrasive,
without actually helping or understanding the big picture. I'm thinking
back on the whole scheduler thing. You weren't arguing with _me_, but you
had the same modus operandi.
Linus
next prev parent reply other threads:[~2008-07-29 15:54 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 20:26 Bizarre missing changes (git bug?) Tim Harper
2008-07-21 20:37 ` Linus Torvalds
2008-07-21 22:53 ` Tim Harper
2008-07-21 22:55 ` Tim Harper
[not found] ` <8C23FB54-A28E-4294-ABEA-A5766200768B@gmail.com>
2008-07-21 22:57 ` Linus Torvalds
2008-07-26 3:12 ` Roman Zippel
2008-07-26 19:58 ` Linus Torvalds
2008-07-27 17:50 ` Roman Zippel
2008-07-27 18:47 ` Linus Torvalds
2008-07-27 23:14 ` Roman Zippel
2008-07-27 23:18 ` Linus Torvalds
2008-07-28 0:00 ` Roman Zippel
2008-07-28 5:00 ` Linus Torvalds
2008-07-28 5:30 ` Linus Torvalds
2008-07-29 2:59 ` Roman Zippel
2008-07-29 3:15 ` Martin Langhoff
2008-07-30 0:16 ` Roman Zippel
2008-07-30 0:25 ` Martin Langhoff
2008-07-30 0:32 ` Linus Torvalds
2008-07-30 0:48 ` Linus Torvalds
2008-07-30 23:56 ` Junio C Hamano
2008-07-31 0:15 ` Junio C Hamano
2008-07-31 0:30 ` Linus Torvalds
2008-07-31 8:17 ` [PATCH v2] revision traversal: show full history with merge simplification Junio C Hamano
2008-07-31 8:18 ` Junio C Hamano
2008-07-31 22:30 ` Linus Torvalds
2008-07-31 22:09 ` [PATCH v3-wip] " Junio C Hamano
2008-07-31 22:26 ` Linus Torvalds
2008-07-31 22:36 ` Junio C Hamano
2008-08-01 3:00 ` Junio C Hamano
2008-08-01 3:48 ` Linus Torvalds
2008-08-01 7:50 ` Junio C Hamano
2008-07-30 8:36 ` Bizarre missing changes (git bug?) Jakub Narebski
2008-07-29 3:29 ` Linus Torvalds
2008-07-29 3:33 ` Linus Torvalds
2008-07-29 11:39 ` Roman Zippel
2008-07-29 12:00 ` David Kastrup
2008-07-29 15:50 ` Linus Torvalds [this message]
2008-07-30 1:14 ` Roman Zippel
2008-07-30 1:32 ` Kevin Ballard
2008-07-30 1:49 ` Linus Torvalds
2008-07-29 5:31 ` Jeff King
2008-07-29 12:32 ` Roman Zippel
2008-07-29 12:48 ` Olivier Galibert
2008-07-29 12:52 ` Jeff King
2008-07-29 17:25 ` Linus Torvalds
2008-07-30 1:50 ` Roman Zippel
2008-07-30 2:05 ` Linus Torvalds
2008-07-30 4:26 ` Jeff King
2008-07-30 4:52 ` Linus Torvalds
2008-07-30 2:48 ` Roman Zippel
2008-07-30 3:20 ` Kevin Ballard
2008-07-30 3:21 ` Linus Torvalds
2008-07-30 3:35 ` Linus Torvalds
2008-07-30 4:23 ` Jeff King
2008-07-27 23:25 ` Martin Langhoff
2008-07-28 1:29 ` Roman Zippel
2008-07-21 20:42 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0807290838360.3334@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=timcharper@gmail.com \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).