From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: Bizarre missing changes (git bug?) Date: Wed, 30 Jul 2008 17:30:57 -0700 (PDT) Message-ID: References: <8502DF7C-5303-49E8-8C67-F837343E2F0C@gmail.com> <200807260512.40088.zippel@linux-m68k.org> <46a038f90807282015m7ce3da10h71dfee221c960332@mail.gmail.com> <7vej5b3ozz.fsf@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Roman Zippel , Martin Langhoff , Tim Harper , Git Mailing List , Johannes Sixt To: Junio C Hamano X-From: git-owner@vger.kernel.org Thu Jul 31 02:36:11 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1KOM9H-0003Rd-Ff for gcvg-git-2@gmane.org; Thu, 31 Jul 2008 02:36:07 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755950AbYGaAfG (ORCPT ); Wed, 30 Jul 2008 20:35:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755549AbYGaAfF (ORCPT ); Wed, 30 Jul 2008 20:35:05 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:51548 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753861AbYGaAfE (ORCPT ); Wed, 30 Jul 2008 20:35:04 -0400 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id m6V0Xw4m019348 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 30 Jul 2008 17:33:59 -0700 Received: from localhost (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id m6V0XuA5027013; Wed, 30 Jul 2008 17:33:57 -0700 In-Reply-To: <7vej5b3ozz.fsf@gitster.siamese.dyndns.org> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) X-Spam-Status: No, hits=-3.407 required=5 tests=AWL,BAYES_00 X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Wed, 30 Jul 2008, Junio C Hamano wrote: > > I am not Roman, but so I do not know if I did what Roman wanted to, but > here is a quick hack. "gitk --post-simplify -- kernel/printk.c" is > slightly more readable than --full-history with this patch. .. and if by "slightly", you mean "a lot", then yes. Patch looks fine to me. I didn't look at the code logic very closely, but I suspect that it's actually hard to get the right answer with broken code, and the logic doesn't look broken. So Ack. The filter-branch thing should probably be taught about this at least as an option. I think it was Johannes Sixt that worried about that one. Added to cc. Linus