git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Pitre <nico@cam.org>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Robin Rosenberg <robin.rosenberg@dewire.com>, git@vger.kernel.org
Subject: Re: [JGIT PATCH 1/2] index-pack: Avoid disk corruption yielding a valid pack footer checksum
Date: Wed, 27 Aug 2008 20:26:07 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.1.10.0808272024160.1624@xanadu.home> (raw)
In-Reply-To: <20080828001401.GT26523@spearce.org>

On Wed, 27 Aug 2008, Shawn O. Pearce wrote:

> Nicolas Pitre <nico@cam.org> wrote:
> > On Wed, 27 Aug 2008, Shawn O. Pearce wrote:
> > > 
> > >   This was inspired by the data corruption thread started
> > >   by J. Bruce Fields.  At some point in the thread Linus
> > >   pointed out the C Git index-pack isn't as safe as it can
> > >   be, and offered a strategy to fix it.
> > 
> > I thought it was Nicolas Pitre who offered that strategy?
> > Maybe I was mistaken.  ;-)
> 
> Sorry about the bad attribution.  Going back through the
> archives does say it was you that had the brilliant idea.

Thanks.  Now my ego is fully restored.  ;-)


Nicolas

      reply	other threads:[~2008-08-28  0:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-27 21:48 [JGIT PATCH 1/2] index-pack: Avoid disk corruption yielding a valid pack footer checksum Shawn O. Pearce
2008-08-27 21:48 ` [JGIT PATCH 2/2] index-pack: Use fsync to ensure received pack data is on disk Shawn O. Pearce
2008-08-28  0:09 ` [JGIT PATCH 1/2] index-pack: Avoid disk corruption yielding a valid pack footer checksum Nicolas Pitre
2008-08-28  0:14   ` Shawn O. Pearce
2008-08-28  0:26     ` Nicolas Pitre [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.10.0808272024160.1624@xanadu.home \
    --to=nico@cam.org \
    --cc=git@vger.kernel.org \
    --cc=robin.rosenberg@dewire.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).