From: Linus Torvalds <torvalds@linux-foundation.org>
To: Petr Baudis <pasky@suse.cz>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Do not perform cross-directory renames when creating packs
Date: Mon, 22 Sep 2008 10:31:47 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0809221029240.3265@nehalem.linux-foundation.org> (raw)
In-Reply-To: <1222104021-28277-1-git-send-email-pasky@suse.cz>
On Mon, 22 Sep 2008, Petr Baudis wrote:
>
> A comment on top of create_tmpfile() describes caveats ('can have
> problems on various systems (FAT, NFS, Coda)') that should apply
> in this situation as well. This in the end did not end up solving
> any of my personal problems, but it might be a useful cleanup patch
> nevertheless.
Side note: the cross-directory avoidance for loose object creation _did_
seem to clear up the original problems reported on NFS, so yes, this is
worth doing. Even if pack-file creation is such a heavy event that I
suspect that none of the timing/caching/whatever issues that were present
for loose objects really ever trigger in practice.
> Signed-off-by: Petr Baudis <pasky@suse.cz>
Looks obvious enough. So:
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Linus
next prev parent reply other threads:[~2008-09-22 17:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 17:20 [PATCH] Do not perform cross-directory renames when creating packs Petr Baudis
2008-09-22 17:31 ` Linus Torvalds [this message]
2008-09-22 23:34 ` [PATCH] builtin-prune.c: prune temporary packs in <object_dir>/pack directory Brandon Casey
2008-09-23 5:37 ` David Tweed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0809221029240.3265@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).