From: Linus Torvalds <torvalds@linux-foundation.org>
To: Davide Libenzi <davidel@xmailserver.org>,
Junio C Hamano <gitster@pobox.com>
Cc: Abhijit Menon-Sen <ams@toroid.org>,
Pierre Habouzit <madcoder@debian.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: absurdly slow git-diff
Date: Fri, 7 Nov 2008 15:57:23 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.0811071554590.3468@nehalem.linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.1.10.0811071547080.8736@alien.or.mcafeemobile.com>
On Fri, 7 Nov 2008, Davide Libenzi wrote:
>
> Yeah, similar. Mine is below. There's one less branch in the for loops.
..and has a comment and made the magic constant be named.
Junio, the time difference is quite big for Abhijit's admittedly odd
test-case:
- Before:
[torvalds@nehalem slow-diff]$ time git diff 1 2 > out.old
real 2m19.912s
user 2m19.885s
sys 0m0.024s
- After:
[torvalds@nehalem slow-diff]$ time ~/git/git diff 1 2 > out
real 0m0.841s
user 0m0.816s
sys 0m0.024s
with no difference in output.
Linus
next prev parent reply other threads:[~2008-11-07 23:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 20:01 absurdly slow git-diff Abhijit Menon-Sen
2008-11-07 21:28 ` Mike Hommey
2008-11-07 21:37 ` Linus Torvalds
2008-11-07 23:04 ` Davide Libenzi
2008-11-07 23:18 ` Davide Libenzi
2008-11-07 23:42 ` Linus Torvalds
2008-11-07 23:48 ` Davide Libenzi
2008-11-07 23:57 ` Linus Torvalds [this message]
2008-11-08 4:57 ` Abhijit Menon-Sen
2008-11-08 21:02 ` Junio C Hamano
2008-11-08 5:30 ` Junio C Hamano
2008-11-08 16:27 ` Davide Libenzi
2008-11-08 0:14 ` Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0811071554590.3468@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=ams@toroid.org \
--cc=davidel@xmailserver.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox