From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: multiple-commit cherry-pick? Date: Fri, 14 Nov 2008 09:41:08 -0800 (PST) Message-ID: References: <20081106213711.GA4334@blimp.localdomain> <7vskq4gmf5.fsf@gitster.siamese.dyndns.org> <20081107071231.GA4063@blimp.localdomain> <20081109102528.GA5463@blimp.localdomain> <81b0412b0811101224gcffc958o6dbfcdc45e022874@mail.gmail.com> <20081114050822.GA23963@foursquare.net> <7v1vxeb4il.fsf@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Chris Frey , Johannes Schindelin , Alex Riesen , Miles Bader , git@vger.kernel.org To: Junio C Hamano X-From: git-owner@vger.kernel.org Fri Nov 14 18:43:25 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1L12hH-0006Lm-11 for gcvg-git-2@gmane.org; Fri, 14 Nov 2008 18:43:07 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755406AbYKNRlp (ORCPT ); Fri, 14 Nov 2008 12:41:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755405AbYKNRlo (ORCPT ); Fri, 14 Nov 2008 12:41:44 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:40823 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755391AbYKNRln (ORCPT ); Fri, 14 Nov 2008 12:41:43 -0500 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id mAEHf9u2012103 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 14 Nov 2008 09:41:10 -0800 Received: from localhost (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id mAEHf8pR012803; Fri, 14 Nov 2008 09:41:09 -0800 In-Reply-To: <7v1vxeb4il.fsf@gitster.siamese.dyndns.org> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) X-Spam-Status: No, hits=-3.432 required=5 tests=AWL,BAYES_00 X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Fri, 14 Nov 2008, Junio C Hamano wrote: > Linus Torvalds writes: > > > So we could make a '{ }' in the argument space basically do a SHA1 > > expansion of the range inside, and imply --no-walk. It's _not_ entirely > > trivial, because we'd need to handle the fact that object flags are > > sticky, and clear them in between invocations of multiple ranges, but it's > > not _fundmanetally_ difficult. It's just that somebody would need to do > > it. > > Wouldn't you lose the nice streaming output (iow short latency)? Oh, absolutely. So the '{x}' format would be not be a replacement for non-{} format - it would be an addition to. But it's no different from 'a..b' in that sense: anything that sets 'revs->limited' automatically forces a synchronous revision walk. So you'd be crazy to do gitk {HEAD} because (a) there would be no point (b) it indeed loses the streaming data and would become synchronous. but if you already do gitk a..b then you're _already_ doing a revision limiter and forcing the revision walk to be synchronous, so there would be no interactivity downside between 'a..b' and '{a..b}'. Linus