From: Linus Torvalds <torvalds@linux-foundation.org>
To: Alan <alan@clueserver.org>
Cc: git@vger.kernel.org
Subject: Re: Odd merge behaviour involving reverts
Date: Thu, 18 Dec 2008 15:58:37 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.0812181534310.14014@localhost.localdomain> (raw)
In-Reply-To: <1229642734.5770.25.camel@rotwang.fnordora.org>
On Thu, 18 Dec 2008, Alan wrote:
>
> What am i doing wrong here?
Reverting a merge is your problem.
You can do it, but you seem to have done it without understanding what it
causes.
A revert of a merge becomes a regular commit that just undoes everything
that the merge did in your branch. When you then do the next merge, you'll
do that merge with that in mind, so now git will essentially consider the
previous merge to be the base line, but your revert undid everything that
that one brought in, so the new merge will really only contain the new
stuff from the branch you are merging.
So if a merge causes problems, you generally should either undo it
_entirely_ (ie do a 'git reset --hard ORIG_HEAD'), not revert it.
Of course, if you had already made the merged state public, or done
development on top of it, you can't really do that. In which case a revert
works, but if you want it back, you should revert the revert, not merge
the branch again - because what you merged last time you threw away, and
won't be applied again.
Linus
next prev parent reply other threads:[~2008-12-19 0:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 23:25 Odd merge behaviour involving reverts Alan
2008-12-18 23:58 ` Linus Torvalds [this message]
2008-12-19 0:11 ` Alan
2008-12-19 0:21 ` Linus Torvalds
2008-12-19 0:35 ` Alan
2008-12-19 0:46 ` Linus Torvalds
2008-12-19 1:30 ` Boyd Stephen Smith Jr.
2008-12-19 3:44 ` Nanako Shiraishi
2008-12-19 4:01 ` Linus Torvalds
2008-12-19 4:18 ` Jay Soffian
2008-12-19 4:23 ` Linus Torvalds
2008-12-19 5:24 ` Daniel Barkalow
2008-12-19 8:45 ` Junio C Hamano
2008-12-19 21:45 ` Nanako Shiraishi
2008-12-19 23:05 ` Junio C Hamano
2008-12-19 23:12 ` Nanako Shiraishi
2008-12-19 23:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0812181534310.14014@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=alan@clueserver.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).