From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: Peter <vmail@mycircuit.org>,
Git Mailing List <git@vger.kernel.org>,
Steve French <sfrench@us.ibm.com>
Subject: Re: fatal: unable to write sha1 file git 1.6.2.1
Date: Tue, 24 Mar 2009 17:11:40 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0903241703290.3032@localhost.localdomain> (raw)
In-Reply-To: <20090324193506.0962b28e@tupile.poochiereds.net>
On Tue, 24 Mar 2009, Jeff Layton wrote:
>
> Yes. That's probably the right thing to do here. This is looks like a
> regression that I introduced some time ago in
> cea218054ad277d6c126890213afde07b4eb1602. Before that delta we always
> flushed all the data before doing any setattr. After that delta, we
> just did it on size changes. In a later commit, Steve fixed it so that
> it got done on ATTR_MTIME too.
Ahh. Yes. You do need to flush on at least ATTR_MODE and ATTR_UID/GID
changes too.
> I wonder though whether that's sufficient. If we're changing ownership
> for instance, will we hit the same issue? Maybe the safest approach is
> just to go back to flushing on any setattr call.
>
> Steve, thoughts?
Is there anything relevant left to be sufficient reason to make it
conditional? Once you're doing it on MODE/SIZE/UID/GID/MTIME changes, that
pretty much will cover all set_attr calls.
Linus
next prev parent reply other threads:[~2009-03-25 0:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 18:20 fatal: unable to write sha1 file git 1.6.2.1 Peter
2009-03-24 19:30 ` Nicolas Pitre
2009-03-24 19:31 ` Linus Torvalds
2009-03-24 21:05 ` Peter
2009-03-24 22:30 ` Linus Torvalds
2009-03-24 22:42 ` Peter
2009-03-25 0:03 ` Linus Torvalds
2009-03-25 0:24 ` Jeff Layton
2009-03-24 23:35 ` Jeff Layton
2009-03-25 0:11 ` Linus Torvalds [this message]
2009-03-25 0:17 ` Steven French
2009-03-25 0:49 ` Jeff Layton
2009-03-25 10:52 ` Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0903241703290.3032@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=jlayton@redhat.com \
--cc=sfrench@us.ibm.com \
--cc=vmail@mycircuit.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox