From: Linus Torvalds <torvalds@linux-foundation.org>
To: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: [PATCH 0/2] speed up reflog unreachability pruning
Date: Tue, 31 Mar 2009 10:03:43 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0903310958000.4093@localhost.localdomain> (raw)
Ok, this is a two-patch series that first tries to clean things up a bit,
and then applies Junio's approach to speed up the reachability test.
The reason I did it this way is that I think we can improve on the
reachability logic a bit more, but in order to do that I refuse to work
with the crazy duplicated complex logic inside 'expire_reflog_ent()', and
I wanted to abstract it out.
Then, the first cut at speedup is just Junio's approach. Which is fairly
hacky, but works.
I'd _like_ to do more of a "dynamically do 'mark_reachable()' only when
necessary" thing, but that's a separate cleanup thing.
As is, this improves the reflog expire quite enormously for me:
- before:
[torvalds@nehalem linux]$ time git reflog expire --all
real 0m37.193s
user 0m37.174s
sys 0m0.020s
- after:
[torvalds@nehalem linux]$ time ~/git/git reflog expire --all
real 0m1.693s
user 0m1.672s
sys 0m0.020s
although I do suspect that the 'mark_reachable()' could slow things down
in some less extreme cases. But probably never by a huge amount.
Total diffstat:
builtin-reflog.c | 75 +++++++++++++++++++++++++++++++++++++++++++++++++----
1 files changed, 69 insertions(+), 6 deletions(-)
with the two individual patches coming up next.
Linus
next reply other threads:[~2009-03-31 17:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-31 17:03 Linus Torvalds [this message]
2009-03-31 17:09 ` [PATCH 1/2] Clean up reflog unreachability pruning decision Linus Torvalds
2009-03-31 17:11 ` [PATCH 2/2] Speed up reflog pruning of unreachable commits Linus Torvalds
2009-03-31 17:46 ` Junio C Hamano
2009-03-31 17:58 ` Linus Torvalds
2009-03-31 17:44 ` [PATCH 1/2] Clean up reflog unreachability pruning decision Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0903310958000.4093@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).