From: Linus Torvalds <torvalds@linux-foundation.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Björn Steinbrink" <B.Steinbrink@gmx.de>,
"Eric Wong" <normalperson@yhbt.net>,
"Anton Gyllenberg" <anton@iki.fi>,
git@vger.kernel.org
Subject: Re: [PATCH] match_tree_entry(): a pathspec only matches at directory boundaries
Date: Thu, 2 Apr 2009 09:36:46 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0904020923180.4130@localhost.localdomain> (raw)
In-Reply-To: <7vwsa3llac.fsf_-_@gitster.siamese.dyndns.org>
On Wed, 1 Apr 2009, Junio C Hamano wrote:
>
> Previously the code did a simple prefix match, which means that a path in
> a directory "frotz/" would have matched with pathspec "f".
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
I have this suspicion that we should be able to write it more readably,
but yes:
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
because the current code is clearly buggy.
Linus
next prev parent reply other threads:[~2009-04-02 16:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 10:31 svn clone Checksum mismatch question Gilbert Liddell
2009-03-26 13:02 ` Björn Steinbrink
2009-03-26 13:28 ` Gilbert Liddell
2009-03-26 13:54 ` Sverre Rabbelier
2009-03-26 14:18 ` Gilbert Liddell
2009-03-26 14:34 ` Johannes Schindelin
2009-03-26 14:35 ` Anton Gyllenberg
2009-03-27 11:18 ` Anton Gyllenberg
2009-03-29 6:08 ` Eric Wong
2009-03-29 6:10 ` [PATCH] git-svn: fix ls-tree usage with dash-prefixed paths Eric Wong
2009-03-29 20:33 ` Junio C Hamano
2009-03-29 21:56 ` Eric Wong
2009-03-30 6:44 ` Junio C Hamano
2009-03-30 17:41 ` Eric Wong
2009-03-30 18:05 ` Junio C Hamano
2009-03-30 22:58 ` Eric Wong
2009-03-31 7:11 ` Björn Steinbrink
2009-03-31 7:31 ` Björn Steinbrink
2009-03-31 9:41 ` Björn Steinbrink
2009-03-31 15:05 ` [PATCH] tree_entry_interesting: Only recurse when the pathspec is a leading path component Björn Steinbrink
2009-04-02 4:32 ` Junio C Hamano
2009-04-02 4:41 ` [PATCH] match_tree_entry(): a pathspec only matches at directory boundaries Junio C Hamano
2009-04-02 16:36 ` Linus Torvalds [this message]
2009-04-02 11:38 ` [PATCH] tree_entry_interesting: Only recurse when the pathspec is a leading path component Björn Steinbrink
2009-04-03 16:25 ` Junio C Hamano
2009-03-30 5:28 ` [PATCH] git-svn: fix ls-tree usage with dash-prefixed paths Björn Steinbrink
2009-03-30 7:26 ` svn clone Checksum mismatch question Anton Gyllenberg
2009-03-26 14:34 ` Peter Harris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0904020923180.4130@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=B.Steinbrink@gmx.de \
--cc=anton@iki.fi \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).