From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [PATCH v2] Add an option not to use link(src, dest) && unlink(src) when that is unreliable Date: Sat, 25 Apr 2009 10:40:15 -0700 (PDT) Message-ID: References: <200904232116.10769.j6t@kdbg.org> <7vbpqkznjs.fsf@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Johannes Schindelin , Johannes Sixt , git@vger.kernel.org To: Junio C Hamano X-From: git-owner@vger.kernel.org Sat Apr 25 19:45:17 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1LxlwA-0007Dg-2m for gcvg-git-2@gmane.org; Sat, 25 Apr 2009 19:45:14 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752880AbZDYRmn (ORCPT ); Sat, 25 Apr 2009 13:42:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751499AbZDYRmn (ORCPT ); Sat, 25 Apr 2009 13:42:43 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:46634 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751214AbZDYRmm (ORCPT ); Sat, 25 Apr 2009 13:42:42 -0400 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n3PHeFnF006953 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 25 Apr 2009 10:40:51 -0700 Received: from localhost (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id n3PHeF3R007957; Sat, 25 Apr 2009 10:40:15 -0700 X-X-Sender: torvalds@localhost.localdomain In-Reply-To: <7vbpqkznjs.fsf@gitster.siamese.dyndns.org> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) X-Spam-Status: No, hits=-3.956 required=5 tests=AWL,BAYES_00,OSDL_HEADER_SUBJECT_BRACKETED X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Sat, 25 Apr 2009, Junio C Hamano wrote: > @@ -2225,7 +2225,9 @@ int move_temp_to_file(const char *tmpfile, const char *filename) > { > int ret = 0; > > - if (link(tmpfile, filename)) > + if (unreliable_hardlinks) > + goto try_rename; Much better. Linus