From: Linus Torvalds <torvalds@linux-foundation.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: Remove diff machinery dependency from read-cache
Date: Thu, 21 Jan 2010 12:15:56 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.1001211215080.13231@localhost.localdomain> (raw)
In-Reply-To: <7vljfrp6g2.fsf@alter.siamese.dyndns.org>
On Thu, 21 Jan 2010, Junio C Hamano wrote:
>
> The patch itself to move add_files_to_cache() to builtin-add.c (or to its
> own file) makes sense from the code placement POV, but if the goal is to
> shrink the on-disk footprint, isn't an alternative approach be to make
> hash-object built-in? You can lose the whole 1.7M from the filesystem
> footprint that way, no?
Sure. Except, as I mentioned, it's not just git-hash-object. It's _all_ of
them.
The total space savings wasn't 1.7M, it was 12M.
Linus
next prev parent reply other threads:[~2010-01-21 20:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 19:37 Remove diff machinery dependency from read-cache Linus Torvalds
2010-01-21 20:07 ` Junio C Hamano
2010-01-21 20:15 ` Linus Torvalds [this message]
2010-01-21 22:18 ` Linus Torvalds
2010-01-21 23:25 ` Linus Torvalds
2010-01-22 0:45 ` Junio C Hamano
2010-01-22 0:59 ` Johannes Schindelin
2010-01-22 1:01 ` Junio C Hamano
2010-01-22 1:43 ` Johannes Schindelin
2010-01-22 3:50 ` Junio C Hamano
2010-01-22 2:20 ` Linus Torvalds
2010-01-22 2:25 ` Linus Torvalds
2010-01-22 3:50 ` Linus Torvalds
2010-01-22 8:43 ` Johannes Sixt
2010-01-22 11:47 ` [PATCH] merge-tree: remove unnecessary call of git_extract_argv0_path Johannes Sixt
2010-01-22 16:40 ` Linus Torvalds
2010-01-22 2:35 ` Remove diff machinery dependency from read-cache Nicolas Pitre
2010-01-22 2:44 ` Linus Torvalds
2010-01-22 3:56 ` Junio C Hamano
2010-01-22 4:21 ` Linus Torvalds
2010-01-22 4:31 ` Linus Torvalds
2010-01-22 3:58 ` Linus Torvalds
2010-01-23 6:31 ` Brian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1001211215080.13231@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).