From: Linus Torvalds <torvalds@linux-foundation.org>
To: Fredrik Kuivinen <frekui@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Johannes Sixt <j.sixt@viscovery.net>
Subject: Re: [PATCH v4] Threaded grep
Date: Tue, 26 Jan 2010 07:28:41 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.1001260728260.3574@localhost.localdomain> (raw)
In-Reply-To: <4c8ef71001260410l2afd2dbx17b6e216bd9e5d8@mail.gmail.com>
On Tue, 26 Jan 2010, Fredrik Kuivinen wrote:
>
> I see the strlen in my profiles as well, but I haven't figured out
> where it comes from.
Looks like this in gdb:
#0 0x0000003e3687f2e0 in __strlen_sse2 () from /lib64/libc.so.6
#1 0x0000003e368c04c5 in regexec@@GLIBC_2.3.4 () from /lib64/libc.so.6
#2 0x000000000047677a in look_ahead (opt=<value optimized out>,
name=<value optimized out>, buf=<value optimized out>,
size=<value optimized out>, collect_hits=<value optimized out>)
at grep.c:679
#3 grep_buffer_1 (opt=<value optimized out>, name=<value optimized out>,
buf=<value optimized out>, size=<value optimized out>,
collect_hits=<value optimized out>) at grep.c:790
so it's sadly internal to regex. It would be nice if there was a
non-string interface to regexec (ie a "buffer + length" instead of a
NUL-terminated string).
> If I use perf record -g I get
I suspect that libc isn't compiled with frame pointers, so call chains end
up being unreliable.
Linus
next prev parent reply other threads:[~2010-01-26 15:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 22:51 [PATCH v4] Threaded grep Fredrik Kuivinen
2010-01-25 23:59 ` Linus Torvalds
2010-01-26 12:10 ` Fredrik Kuivinen
2010-01-26 15:28 ` Linus Torvalds [this message]
2010-01-26 16:30 ` Benjamin Kramer
2010-01-26 16:44 ` Linus Torvalds
2010-01-26 16:56 ` Linus Torvalds
2010-01-26 17:19 ` Mike Hommey
2010-01-26 17:48 ` [PATCH] grep: use REG_STARTEND (if available) to speed up regexec Benjamin Kramer
2010-01-26 1:20 ` [PATCH v4] Threaded grep Junio C Hamano
2010-01-26 11:43 ` Fredrik Kuivinen
2010-01-26 17:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1001260728260.3574@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=frekui@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).