From: Nicolas Pitre <nico@fluxnic.net>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 3/3] make --max-pack-size argument to 'git pack-object' count in bytes
Date: Thu, 04 Feb 2010 12:58:11 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.1002041249200.1681@xanadu.home> (raw)
In-Reply-To: <20100204172421.GA18548@spearce.org>
On Thu, 4 Feb 2010, Shawn O. Pearce wrote:
> How about for a transition period we do:
>
> if (v < 8192) {
> warning("max-pack-size is now in bytes, assuming %dm", v);
> v *= 1024 * 1024;
> }
>
> So that existing users won't be completely broken if they are
> relying on this flag, and have some time to adjust.
For 'git fast-import' which is not meant to be directly user operated
this makes sense. I don't think this is a good idea for 'git repack'
though. In the later case it is best if the user simply adjust right
away.
Also the warning text above could be less ambigous. Something like:
"max-pack-size is now in bytes, assuming --max-pack-size=%dm"
Nicolas
next prev parent reply other threads:[~2010-02-04 17:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 3:48 [PATCH 1/3] fix multiple issues with t5300 Nicolas Pitre
2010-02-04 3:48 ` [PATCH 2/3] pack-objects: fix pack generation when using pack_size_limit Nicolas Pitre
2010-02-04 3:48 ` [PATCH 3/3] make --max-pack-size argument to 'git pack-object' count in bytes Nicolas Pitre
2010-02-04 4:00 ` Shawn O. Pearce
2010-02-04 4:38 ` Junio C Hamano
2010-02-04 17:11 ` Junio C Hamano
2010-02-04 17:24 ` Shawn O. Pearce
2010-02-04 17:58 ` Nicolas Pitre [this message]
2010-02-04 17:59 ` Shawn O. Pearce
2010-02-04 19:10 ` [PATCH] fast-import: count --max-pack-size " Junio C Hamano
2010-02-04 19:13 ` Shawn O. Pearce
2010-02-04 20:03 ` Ilari Liusvaara
2010-02-04 17:49 ` [PATCH 3/3] make --max-pack-size argument to 'git pack-object' count " Nicolas Pitre
2010-02-04 18:00 ` Shawn O. Pearce
2010-02-04 18:11 ` Nicolas Pitre
2010-02-04 21:20 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1002041249200.1681@xanadu.home \
--to=nico@fluxnic.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).