From: Linus Torvalds <torvalds@linux-foundation.org>
To: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
Cc: gitster@pobox.com, git@vger.kernel.org,
Jeremy White <jwhite@codeweavers.com>,
Robert Shearman <robertshearman@gmail.com>
Subject: Re: [PATCH 4/4] git-imap-send: Add method to convert from LF to CRLF
Date: Tue, 9 Feb 2010 09:24:51 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.1002090918180.3829@localhost.localdomain> (raw)
In-Reply-To: <1265717345-2118-5-git-send-email-mitake@dcl.info.waseda.ac.jp>
On Tue, 9 Feb 2010, Hitoshi Mitake wrote:
>
> Some strict IMAP servers (e.g. Cyrus) don't
> allow "bare newlines ('\n')" in messages.
> So I added new boolean option "lf-to-crlf" to imap section.
> If this option enabled, git-imap-send converts LF to CRLF("\r\n").
>
> If you want to use it, add line:
> lf-to-crlf
> to [imap] section of your .gitconfig .
Hmm. Should this even be an option? Maybe we should _always_ do CRLF. That
does seem to be the technically correct thing to do for SMTP and IMAP.
rfc2822 (smtp) is pretty clear that CRLF is the line ending, and neither
CR nor LF must ever be sent individually. That's true both for headers and
the body of the email. The same goes for rfc3501 (imap).
So I suspect that CRLF should be unconditional.
Linus
next prev parent reply other threads:[~2010-02-09 17:26 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-06 19:26 imap.preformattedHTML and imap.sslverify Junio C Hamano
2010-02-08 22:31 ` Jeremy White
2010-02-08 23:05 ` Junio C Hamano
2010-02-09 12:09 ` [PATCH 0/4] Some improvements for git-imap-send Hitoshi Mitake
2010-02-09 15:06 ` Jeff King
2010-02-09 15:13 ` Erik Faye-Lund
2010-02-09 16:57 ` Jeff King
2010-02-09 18:37 ` Erik Faye-Lund
2010-02-09 18:54 ` Jeff King
2010-02-11 14:38 ` [PATCH v2 1/2] git-imap-send: Add CRAM-MD5 authenticate method support Hitoshi Mitake
2010-02-11 14:55 ` Erik Faye-Lund
2010-02-11 14:59 ` Hitoshi Mitake
2010-02-11 15:06 ` [PATCH v3 " Hitoshi Mitake
2010-02-11 20:30 ` Junio C Hamano
2010-02-12 11:23 ` Hitoshi Mitake
2010-02-11 14:38 ` [PATCH v2 2/2] git-imap-send: Convert LF to CRLF before storing patch to draft box Hitoshi Mitake
2010-02-11 20:48 ` Junio C Hamano
2010-02-12 11:24 ` Hitoshi Mitake
2010-02-11 14:45 ` [PATCH v2 1/2] git-imap-send: Add CRAM-MD5 authenticate method support Hitoshi Mitake
2010-02-11 14:45 ` [PATCH v2 2/2] git-imap-send: Convert LF to CRLF before storing patch to draft box Hitoshi Mitake
2010-02-12 11:36 ` [PATCH v4 1/2] git-imap-send: Add CRAM-MD5 authenticate method support Hitoshi Mitake
2010-02-12 12:41 ` Erik Faye-Lund
2010-02-13 4:21 ` Hitoshi Mitake
2010-02-12 21:44 ` Junio C Hamano
2010-02-13 6:49 ` Hitoshi Mitake
2010-02-13 6:56 ` [PATCH v5 " Hitoshi Mitake
2010-02-13 7:42 ` [PATCH v4 " Junio C Hamano
2010-02-16 6:34 ` Junio C Hamano
2010-02-17 9:17 ` Hitoshi Mitake
2010-02-17 9:18 ` [PATCH v6 " Hitoshi Mitake
2010-02-17 18:31 ` [PATCH v4 " Junio C Hamano
2010-02-18 15:45 ` Hitoshi Mitake
2010-02-17 8:51 ` Hitoshi Mitake
2010-02-12 11:36 ` [PATCH v4 2/2] git-imap-send: Convert LF to CRLF before storing patch to draft box Hitoshi Mitake
2010-02-09 12:09 ` [PATCH 1/4] Add base64 encoder and decoder Hitoshi Mitake
2010-02-09 14:45 ` Erik Faye-Lund
2010-02-11 14:37 ` Hitoshi Mitake
2010-02-09 12:09 ` [PATCH 2/4] Add stuffs for MD5 hash algorithm Hitoshi Mitake
2010-02-09 12:09 ` [PATCH 3/4] git-imap-send: Implement CRAM-MD5 auth method Hitoshi Mitake
2010-02-09 14:22 ` Erik Faye-Lund
2010-02-11 14:55 ` Hitoshi Mitake
2010-02-11 14:59 ` Erik Faye-Lund
2010-02-11 15:11 ` Hitoshi Mitake
2010-02-09 12:09 ` [PATCH 4/4] git-imap-send: Add method to convert from LF to CRLF Hitoshi Mitake
2010-02-09 16:15 ` Jakub Narebski
2010-02-11 14:37 ` Hitoshi Mitake
2010-02-09 17:24 ` Linus Torvalds [this message]
2010-02-09 18:20 ` Junio C Hamano
2010-02-11 14:38 ` Hitoshi Mitake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1002090918180.3829@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jwhite@codeweavers.com \
--cc=mitake@dcl.info.waseda.ac.jp \
--cc=robertshearman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox