From: Linus Torvalds <torvalds@linux-foundation.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>,
Junio C Hamano <gitster@pobox.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [JGIT PATCH 2/2] Make Repository.isValidRefName compatible with Git 1.6.3
Date: Thu, 7 May 2009 16:29:21 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.01.0905071620240.4983@localhost.localdomain> (raw)
In-Reply-To: <200905080102.44053.robin.rosenberg@dewire.com>
On Fri, 8 May 2009, Robin Rosenberg wrote:
>
> In 3e262b95c509 I taught C Git to disallow refs whose names end in
> ".lock".
Btw, I think we should revert that, and instead change our naming for
lock-files.
It's a silly limitation, and for a stupid reason, I think. I can well
imagine people using a branch naming policy of using '.' instead of
spaces, and then It makes perfect sense to call a branch "fix.vm.lock"
when you have a VM locking issue you want to fix.
So I think we should remove that stupid "*.lock" rule from the C version
(and then obviously from the JGIT one too).
Now, that leaves what we _should_ call the lock-files, and the only sane
thing to do is to pick a sequence that is already invalid for other
reasons. We could make the lockfile end in "..lock", for example (".." is
not legal in names due to the confusion with the "a..b" range notation),
or just end or begin with a "." (same issue, except "..." now).
Or just make it end in '~' which is also invalid for similar reasons.
Linus
next prev parent reply other threads:[~2009-05-07 23:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 15:05 [JGIT PATCH 1/2] Add support for boolean config values "yes", "no" Shawn O. Pearce
2009-05-07 15:05 ` [JGIT PATCH 2/2] Make Repository.isValidRefName compatible with Git 1.6.3 Shawn O. Pearce
2009-05-07 23:02 ` Robin Rosenberg
2009-05-07 23:29 ` Linus Torvalds [this message]
2009-05-08 0:32 ` Junio C Hamano
2009-05-08 0:47 ` Shawn O. Pearce
2009-05-08 7:24 ` Alex Riesen
2009-05-08 8:04 ` Johannes Schindelin
2009-05-08 8:43 ` Junio C Hamano
2009-05-08 9:54 ` Johannes Schindelin
2009-05-08 11:45 ` Alex Riesen
2009-05-08 14:34 ` Shawn O. Pearce
[not found] ` <7viqkcbenb.fsf_-_@alter.siamese.dyndns.org>
2009-05-08 0:54 ` [PATCH] Allow branch names that end with ".lock" Shawn O. Pearce
2009-05-08 0:57 ` Junio C Hamano
2009-05-08 1:01 ` Shawn O. Pearce
2009-05-08 1:25 ` Junio C Hamano
2009-05-07 17:56 ` [JGIT PATCH 1/2] Add support for boolean config values "yes", "no" Brandon Casey
2009-05-07 18:01 ` [JGIT PATCH v2 1/2] Add support for boolean config values "on", "off" Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0905071620240.4983@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=robin.rosenberg@dewire.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).