From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: Funny error with git gc... Date: Fri, 15 May 2009 13:08:49 -0700 (PDT) Message-ID: References: <7vmy9etey8.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Junio C Hamano , git@vger.kernel.org To: Johannes Schindelin X-From: git-owner@vger.kernel.org Fri May 15 22:09:07 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1M53iM-0004lu-D4 for gcvg-git-2@gmane.org; Fri, 15 May 2009 22:09:06 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751740AbZEOUI4 (ORCPT ); Fri, 15 May 2009 16:08:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751500AbZEOUI4 (ORCPT ); Fri, 15 May 2009 16:08:56 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:43569 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751423AbZEOUIz (ORCPT ); Fri, 15 May 2009 16:08:55 -0400 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n4FK8oet009515 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 15 May 2009 13:08:51 -0700 Received: from localhost (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id n4FK8n9l018433; Fri, 15 May 2009 13:08:49 -0700 X-X-Sender: torvalds@localhost.localdomain In-Reply-To: User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) X-Spam-Status: No, hits=-3.463 required=5 tests=AWL,BAYES_00 X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Fri, 15 May 2009, Johannes Schindelin wrote: > > fd = mkstemp(template); > + if (fd < 0) { > + release_pack_memory((size_t)-1ll, -1); > + fd = mkstemp(template); This is wrong. You can't use "template" twice. You need to re-initialize it. The first one will blow away the XXXX pattern. Linus