git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Catalin Marinas <catalin.marinas@gmail.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	Git Mailing List <git@vger.kernel.org>,
	Karl Wiberg <kha@treskal.com>
Subject: Re: [ANNOUNCE] Stacked Git 0.15-rc1
Date: Mon, 13 Jul 2009 15:57:31 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.2.01.0907131555200.13838@localhost.localdomain> (raw)
In-Reply-To: <b0943d9e0907131506s329bc2c2qe35180ac783a52f3@mail.gmail.com>



On Mon, 13 Jul 2009, Catalin Marinas wrote:
> 
>      os.environ.setdefault('PAGER', config.get('stgit.pager'))
> +    if os.environ.get('PAGER').startswith('less'):
> +        os.environ.setdefault('LESS', '-FRSX')
>      # FIXME: handle EDITOR the same way ?

That's not very smart.

First off, PAGER could easily be something like "/usr/local/bin/less".

Secondly, if it isn't less, so what? If it's not less, it won't care about 
the LESS environment variable.

So just do an unconditional

	os.environ.setdefault('LESS', '-FRSX')

and it will (a) work better, (b) be simpler and more efficient.

		Linus

  reply	other threads:[~2009-07-13 22:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-12 22:40 [ANNOUNCE] Stacked Git 0.15-rc1 Catalin Marinas
2009-07-13  8:28 ` Uwe Kleine-König
2009-07-14 14:12   ` Catalin Marinas
2009-07-13 13:10 ` Karl Wiberg
2009-07-13 13:33 ` Aneesh Kumar K.V
2009-07-13 17:07   ` Catalin Marinas
2009-07-13 17:20     ` Aneesh Kumar K.V
2009-07-13 17:47       ` Aneesh Kumar K.V
2009-07-13 22:06         ` Catalin Marinas
2009-07-13 22:57           ` Linus Torvalds [this message]
2009-07-14  8:24             ` Catalin Marinas
2009-07-14 17:52 ` Larry D'Anna
2009-07-14 21:05   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.01.0907131555200.13838@localhost.localdomain \
    --to=torvalds@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=catalin.marinas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kha@treskal.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).