git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] shortlog: add '--sort-key' and '--sort-key-regexp' options
Date: Wed, 15 Jul 2009 08:11:57 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.2.01.0907150807401.13838@localhost.localdomain> (raw)
In-Reply-To: <alpine.DEB.1.00.0907151316320.4410@intel-tinevez-2-302>



On Wed, 15 Jul 2009, Johannes Schindelin wrote:
> 
> Instead of always sorting by author, allow to sort by either
> a whitespace-delimited field or by a regular expression (first group)
> on the oneline.

Ok, I got a SIGSEGV on the regexp, because I didn't react to the "first 
group" part. So I did

	git shortlog --pretty=%cD --sort-key-regex ' [0-9]*:' -ns

and it immediately segfaulted for me.

I realize that I _should_ have done

	git shortlog --pretty=%cD --sort-key-regex ' \([0-9]*\):' -ns

and then I get the expected hourly statistics, but it shouldn't have 
SIGSEGV'd either.

But cool small patch-series. This was exactly what I was looking for.

		Linus

  reply	other threads:[~2009-07-15 15:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-15  2:07 More 'shortlog' statistics models? Linus Torvalds
2009-07-15  8:24 ` Junio C Hamano
2009-07-15 11:16   ` [PATCH 1/2] shortlog: refactor insert_one_record() Johannes Schindelin
2009-07-15 11:17   ` [PATCH 2/2] shortlog: add '--sort-key' and '--sort-key-regexp' options Johannes Schindelin
2009-07-15 15:11     ` Linus Torvalds [this message]
2009-07-15 15:37     ` Michał Kiedrowicz
2009-07-15 13:38   ` More 'shortlog' statistics models? Jakub Narebski
2009-07-15 17:56     ` Sverre Rabbelier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.01.0907150807401.13838@localhost.localdomain \
    --to=torvalds@linux-foundation.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).