git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Git Mailing List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: three-way diff performance problem
Date: Tue, 21 Jul 2009 11:16:32 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.2.01.0907211113260.19335@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.01.0907211038120.19335@localhost.localdomain>



On Tue, 21 Jul 2009, Linus Torvalds wrote:
> 
> Now, being a git person, what does that say? Right: just check in the 
> working kernels as two branches under the same filename, then merge the 
> branches, and force the merge result to be the non-working kernel, and do 
> a three-way combined context diff! So I did exactly that.

Btw, I did it wrong, which is why it takes too long. Instead of making the 
result be the right dump-file, I made it be a bad one, so the diffs are 
much bigger than they should be. Which then makes the combined-merge diff 
take longer than necessary (with the O(n^2) thing).

Doing it _correctly_ actually made the three-way diff only take 45 
seconds, but sadly still left me with 22 thousand lines.

			Linus

  reply	other threads:[~2009-07-21 18:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-21 18:10 three-way diff performance problem Linus Torvalds
2009-07-21 18:16 ` Linus Torvalds [this message]
2009-07-21 19:21 ` Junio C Hamano
2009-07-21 19:31   ` Linus Torvalds
2009-07-21 19:47   ` Junio C Hamano
2009-07-21 20:34     ` Linus Torvalds
2009-07-21 20:46       ` Junio C Hamano
2009-07-21 21:01         ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.01.0907211113260.19335@localhost.localdomain \
    --to=torvalds@linux-foundation.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).