From: Linus Torvalds <torvalds@linux-foundation.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: Add '--bisect' revision machinery argument
Date: Wed, 28 Oct 2009 16:32:59 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.01.0910281631400.31845@localhost.localdomain> (raw)
In-Reply-To: <7viqdzgls9.fsf@alter.siamese.dyndns.org>
On Wed, 28 Oct 2009, Junio C Hamano wrote:
>
> This shows a very nice direction to evolve, but your patch as-is breaks
> "rev-list --bisect", I think.
I think you're right. I tested git rev-parse, and the 'git log' machinery,
but I didn't think about the fact that we already had a meaning
for '--bisect' in rev-list.
> Also, the helper of "git bisect" can and probably should be taught to just
> ask this new behaviour from the revision machinery, instead of collecting
> good and bad refs itself using bisect.c::read_bisect_refs().
Yeah. And git-bisect.sh can be simplified too.
Linus
next prev parent reply other threads:[~2009-10-28 23:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 18:28 Add '--bisect' revision machinery argument Linus Torvalds
2009-10-28 7:18 ` Junio C Hamano
2009-10-28 23:07 ` Junio C Hamano
2009-10-28 23:32 ` Linus Torvalds [this message]
2009-10-31 20:58 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0910281631400.31845@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox