From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Sybille Peters <sypets@gmx.de>
Cc: Git Mailing list <git@vger.kernel.org>
Subject: Re: error(?) in "man git-stash" regarding "--keep-index"
Date: Fri, 18 May 2018 11:43:48 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.21.1805181141030.10462@localhost.localdomain> (raw)
In-Reply-To: <96486abe-cf13-ef10-7513-2d6c20a9dc1e@gmx.de>
On Fri, 18 May 2018, Sybille Peters wrote:
> My 2c on this:
>
> 1) "If the --keep-index option is used, all changes already added to
> the index are left intact" (manpage git stash)
>
> That appears to be correct and clear
yup, that's not the issue.
> 2) "$ git stash push --keep-index # save *all other* changes to the
> stash" (manpage git stash)
>
> That is either not correct or misleading. "All other" implies in my
> opinion all changes except the ones that were already added. *"All
> changes including already staged changes"* might be a better choice.
yup, that is *exactly* the point i was trying to make.
rday
next prev parent reply other threads:[~2018-05-18 15:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 9:37 error(?) in "man git-stash" regarding "--keep-index" Robert P. J. Day
2018-05-18 10:41 ` Martin Ågren
2018-05-18 10:51 ` Robert P. J. Day
2018-05-18 12:25 ` Martin Ågren
2018-05-18 15:37 ` Sybille Peters
2018-05-18 15:43 ` Robert P. J. Day [this message]
2018-05-18 17:14 ` Martin Ågren
2018-05-19 10:05 ` Sybille Peters
2018-05-18 20:24 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1805181141030.10462@localhost.localdomain \
--to=rpjday@crashcourse.ca \
--cc=git@vger.kernel.org \
--cc=sypets@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).