Git development
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Duy Nguyen <pclouds@gmail.com>, Git Mailing list <git@vger.kernel.org>
Subject: Re: is there a reason pre-commit.sample uses "git diff-index"?
Date: Thu, 31 May 2018 19:09:03 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.21.1805311907280.19720@localhost.localdomain> (raw)
In-Reply-To: <f27d8344-4acb-3e87-3bd9-b23b21c4b82a@kdbg.org>

On Fri, 1 Jun 2018, Johannes Sixt wrote:

> Am 31.05.2018 um 19:27 schrieb Robert P. J. Day:
> > On Thu, 31 May 2018, Duy Nguyen wrote:
> >> git diff-index is "plumbing", designed for writing scripts. "git
> >> diff" on the other hand is for users and its behavior may change
> >> even if it breaks backward compatibility.
> >
> >    ah, this was a philosophical underpinning i was unaware of. i
> > see occasional explanations of git porcelain versus plumbing, but
> > i don't recall anyone simply stating that the plumbing is meant to
> > have a long-term stability that is not guaranteed for the
> > porcelain.
>
> So, there you have it. ;) Plumbing commands offer long-term
> stability. That is not just philosophical, but practically relevant.
>
> >    in any event, this does mean that, stability issues aside, "git
> > diff" would apparently have worked just fine for that hook.
>
> It may have worked just fine. You should still not use it.
>
> Didn't you say that you are teaching git and hooks? Then you should
> teach the right thing, and the right thing is to use plumbing for
> scripts.

  sure, i agree, but i don't recall *ever* running across the claim
that the "plumbing" commands had a long-term stability and backward
compatibility that the porcelain commands did not. is that mentioned
anywhere?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                  http://crashcourse.ca/dokuwiki

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

  reply	other threads:[~2018-05-31 23:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-31 16:38 is there a reason pre-commit.sample uses "git diff-index"? Robert P. J. Day
2018-05-31 17:05 ` Duy Nguyen
2018-05-31 17:27   ` Robert P. J. Day
2018-05-31 17:41     ` Duy Nguyen
2018-05-31 23:08     ` Johannes Sixt
2018-05-31 23:09       ` Robert P. J. Day [this message]
2018-05-31 23:25         ` Stefan Beller
2018-06-01  2:23           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.21.1805311907280.19720@localhost.localdomain \
    --to=rpjday@crashcourse.ca \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox