From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Git Mailing list <git@vger.kernel.org>
Subject: [PATCH v2] t/perf/run: Use proper "--get-regexp", not "--get-regex"
Date: Sun, 3 Jun 2018 06:14:44 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.21.1806030613080.7681@localhost.localdomain> (raw)
Even though "--get-regex" appears to work with "git config", the
clear standard is to spell out the action in full.
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
this is the only occurrence i saw of this in the entire code base, so
it seemed worth tweaking just for consistency.
diff --git a/t/perf/run b/t/perf/run
index 9aaa733c7..fb5753ea2 100755
--- a/t/perf/run
+++ b/t/perf/run
@@ -110,7 +110,7 @@ run_dirs () {
get_subsections () {
section="$1"
test -z "$GIT_PERF_CONFIG_FILE" && return
- git config -f "$GIT_PERF_CONFIG_FILE" --name-only --get-regex "$section\..*\.[^.]+" |
+ git config -f "$GIT_PERF_CONFIG_FILE" --name-only --get-regexp "$section\..*\.[^.]+" |
sed -e "s/$section\.\(.*\)\..*/\1/" | sort | uniq
}
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca/dokuwiki
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
next reply other threads:[~2018-06-03 10:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-03 10:14 Robert P. J. Day [this message]
2018-06-03 13:30 ` [PATCH v2] t/perf/run: Use proper "--get-regexp", not "--get-regex" Thomas Gummerer
2018-06-03 13:36 ` Robert P. J. Day
2018-06-03 15:33 ` Philip Oakley
2018-06-04 11:03 ` Robert P. J. Day
2018-06-04 13:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1806030613080.7681@localhost.localdomain \
--to=rpjday@crashcourse.ca \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).