git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] t/perf/run: Use proper "--get-regexp", not "--get-regex"
@ 2018-06-03 10:14 Robert P. J. Day
  2018-06-03 13:30 ` Thomas Gummerer
  0 siblings, 1 reply; 6+ messages in thread
From: Robert P. J. Day @ 2018-06-03 10:14 UTC (permalink / raw)
  To: Git Mailing list


Even though "--get-regex" appears to work with "git config", the
clear standard is to spell out the action in full.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

this is the only occurrence i saw of this in the entire code base, so
it seemed worth tweaking just for consistency.

diff --git a/t/perf/run b/t/perf/run
index 9aaa733c7..fb5753ea2 100755
--- a/t/perf/run
+++ b/t/perf/run
@@ -110,7 +110,7 @@ run_dirs () {
 get_subsections () {
 	section="$1"
 	test -z "$GIT_PERF_CONFIG_FILE" && return
-	git config -f "$GIT_PERF_CONFIG_FILE" --name-only --get-regex "$section\..*\.[^.]+" |
+	git config -f "$GIT_PERF_CONFIG_FILE" --name-only --get-regexp "$section\..*\.[^.]+" |
 	sed -e "s/$section\.\(.*\)\..*/\1/" | sort | uniq
 }


-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                  http://crashcourse.ca/dokuwiki

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-06-04 13:33 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-03 10:14 [PATCH v2] t/perf/run: Use proper "--get-regexp", not "--get-regex" Robert P. J. Day
2018-06-03 13:30 ` Thomas Gummerer
2018-06-03 13:36   ` Robert P. J. Day
2018-06-03 15:33     ` Philip Oakley
2018-06-04 11:03       ` Robert P. J. Day
2018-06-04 13:33         ` Junio C Hamano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).