From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Kevin Daudt <me@ikke.info>
Cc: Git Mailing list <git@vger.kernel.org>
Subject: Re: "git add -p" versus "git add -i", followed by "p"
Date: Sun, 2 Dec 2018 11:59:53 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.21.1812021158370.6459@localhost.localdomain> (raw)
In-Reply-To: <20181202165242.GA4823@alpha>
On Sun, 2 Dec 2018, Kevin Daudt wrote:
> On Sun, Dec 02, 2018 at 11:30:19AM -0500, Robert P. J. Day wrote:
> >
> > testing adding by patch for the very first time (i've just never
> > needed this), and reading the "progit" book and reading the man page,
> > and the impression i'm getting is that running "git add -p" (going
> > straight to patch mode) is supposed to be equivalent to running "git
> > add -i", then typing "p" to switch to patch mode.
> >
> > that is most emphatically not what i'm seeing. if i run "git add
> > -p", then i get to what i expect -- the patch subsystem:
> >
> > $ git add -p
> > diff --git a/README.asc b/README.asc
> > index fa40bad..840e85b 100644
> > --- a/README.asc
> > +++ b/README.asc
> > @@ -1,3 +1,9 @@
> > +change 1
> > +
> > +
> > +
> > +
> > +
> > = Pro Git, Second Edition
> >
> > Welcome to the second edition of the Pro Git book.
> > Stage this hunk [y,n,q,a,d,j,J,g,/,e,?]?
> >
> > but if i start with "git add -i", there seems to be no way to get
> > to patch mode -- certainly "p" doesn't do it. am i stupidly
> > missing something trivial? is the explanation misleading or
> > inncomplete?
>
> After selecting 'p', what do you get?
>
> You should see a list of modified files. You can select the files
> you want to stage by the listed numbers. After you selected those
> files, you press enter, and then you will get the options you'll
> also see with git add -p.
$ git add -i
staged unstaged path
1: unchanged +12/-0 README.asc
*** Commands ***
1: [s]tatus 2: [u]pdate 3: [r]evert 4: [a]dd untracked
5: [p]atch 6: [d]iff 7: [q]uit 8: [h]elp
What now> p
staged unstaged path
1: unchanged +12/-0 [R]EADME.asc
Patch update>> 1
staged unstaged path
* 1: unchanged +12/-0 [R]EADME.asc
Patch update>> 1
staged unstaged path
* 1: unchanged +12/-0 [R]EADME.asc
Patch update>>
and ... then what?
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca/dokuwiki
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
next prev parent reply other threads:[~2018-12-02 16:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-02 16:30 "git add -p" versus "git add -i", followed by "p" Robert P. J. Day
2018-12-02 16:52 ` Kevin Daudt
2018-12-02 16:59 ` Robert P. J. Day [this message]
2018-12-02 16:56 ` SZEDER Gábor
2018-12-02 17:01 ` Robert P. J. Day
2018-12-02 17:03 ` Robert P. J. Day
2018-12-02 17:09 ` Duy Nguyen
2018-12-02 17:30 ` Robert P. J. Day
2018-12-08 16:22 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1812021158370.6459@localhost.localdomain \
--to=rpjday@crashcourse.ca \
--cc=git@vger.kernel.org \
--cc=me@ikke.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).