Git development
 help / color / mirror / Atom feed
From: Daniel Barkalow <barkalow@iabervon.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH 3/9] Send unpack-trees debugging output to stderr
Date: Tue, 5 Feb 2008 15:38:35 -0500 (EST)	[thread overview]
Message-ID: <alpine.LNX.1.00.0802042118420.13593@iabervon.org> (raw)
In-Reply-To: <alpine.LSU.1.00.0802050117410.8543@racer.site>

On Tue, 5 Feb 2008, Johannes Schindelin wrote:

> Hi,
> 
> On Mon, 4 Feb 2008, Daniel Barkalow wrote:
> 
> >  #if DBRT_DEBUG > 1
> >  		if (first)
> > -			printf("index %s\n", first);
> > +			fprintf(stderr, "index %s\n", first);
> >  #endif
> 
> This code path is only affected when DBRT_DEBUG is defined ("Daniel 
> Barkalow's Roasted Tomatoes"?).  So technically, I do not really see why 
> this is part of this patch series...

"Daniel Barkalow's read_tree" (which is what that code was called when it 
was added). I needed to enable this debugging in order to debug this 
series, and found that enabling debugging caused tests to fail, so I fixed 
that in the series. To the extent that this matters at all, having it in 
the series that could need debugging makes sense.

	-Daniel
*This .sig left intentionally blank*

  reply	other threads:[~2008-02-05 20:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-04 18:35 [PATCH 3/9] Send unpack-trees debugging output to stderr Daniel Barkalow
2008-02-05  1:20 ` Johannes Schindelin
2008-02-05 20:38   ` Daniel Barkalow [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-01-25 23:24 Daniel Barkalow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.1.00.0802042118420.13593@iabervon.org \
    --to=barkalow@iabervon.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox