From: Daniel Barkalow <barkalow@iabervon.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH 7/9] Export create_branch() from builtin-branch.c
Date: Tue, 5 Feb 2008 15:39:02 -0500 (EST) [thread overview]
Message-ID: <alpine.LNX.1.00.0802042139170.13593@iabervon.org> (raw)
In-Reply-To: <alpine.LSU.1.00.0802050136440.8543@racer.site>
On Tue, 5 Feb 2008, Johannes Schindelin wrote:
> Hi,
>
> On Mon, 4 Feb 2008, Daniel Barkalow wrote:
>
> > You can also create branches, in exactly the same way, with checkout -b.
> >
> > Signed-off-by: Daniel Barkalow <barkalow@iabervon.org>
> > ---
> > builtin-branch.c | 4 ++--
> > cache.h | 4 ++++
>
> Note that builtin-branch.c is not part of libgit.a, so you are only moving
> the declaration into the "libgit" part.
>
> Maybe it would be better to move this function, say, into refs.c?
I think it's actually time to start a branch.{c,h} library file for
operations that deal with the porcelain-ish information about branches.
This would go there, and a function to discard MERGE_HEAD and similar
files (whatever they are, which isn't currently collected anywhere
authoritative). Probably also most of the other stuff that should be
shared between reset and checkout, too, and functions should probably
migrate there from builtin-branch and builtin-checkout as they become
needed, leaving the builtin-* code as command-line parsing and calls to
these functions. In any case, I'll start with this.
-Daniel
*This .sig left intentionally blank*
next prev parent reply other threads:[~2008-02-05 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-04 18:36 [PATCH 7/9] Export create_branch() from builtin-branch.c Daniel Barkalow
2008-02-05 1:38 ` Johannes Schindelin
2008-02-05 20:39 ` Daniel Barkalow [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-01-25 23:25 Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.1.00.0802042139170.13593@iabervon.org \
--to=barkalow@iabervon.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox