From: Boyd Lynn Gerber <gerberb@zenez.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Aidan Van Dyk <aidan@highrise.ca>, git@vger.kernel.org
Subject: Re: Compile fix for SCO OPenServer
Date: Wed, 30 Jul 2008 14:09:03 -0600 [thread overview]
Message-ID: <alpine.LNX.1.10.0807301403360.13032@xenau.zenez.com> (raw)
In-Reply-To: <7vtze73zwg.fsf@gitster.siamese.dyndns.org>
On Wed, 30 Jul 2008, Junio C Hamano wrote:
> Aidan Van Dyk <aidan@highrise.ca> writes:
> > SCO OpenServer also hides the definitions of (at least) u_short and
> > friends if _XOPEN_SOURCE is defined.
>
> I thought that was covered by 457bb45 (Port to 12 other Platforms., 2008-06-08).
I thought it was covered as well.
> Sign-off?
>
> Boyd, does this make any of the earlier symbols you added redundant?
I have just tried this on 4 OpenServer 6.0 machines fresh installed and I
do not need this added. I am trying to figure out what is different on
his. It appears he is using the exact same version of the compiler as
well.
My uname -a gives me this...
SCO_SV tech0 5 6.0.0 i386
and the gcc -V gives me the exact same compiler. So I do not know why he
has to have the additional __OPENSERVER__. This does break my OpenServer
5.0.7 fresh install as well. So I would not use it. What I do not
understand is why the !defined(__USLC__) does not catch it. It should.
> > git-compat-util.h | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/git-compat-util.h b/git-compat-util.h
> > index cf89cdf..42e3e0b 100644
> > --- a/git-compat-util.h
> > +++ b/git-compat-util.h
> > @@ -39,7 +39,7 @@
> > /* Approximation of the length of the decimal representation of this type. */
> > #define decimal_length(x) ((int)(sizeof(x) * 2.56 + 0.5) + 1)
> >
> > -#if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__USLC__) && !defined(_M_UNIX)
> > +#if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__USLC__) && !defined(_M_UNIX) && !defined(__OPENSERVER__)
> > #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */
> > #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */
> > #endif
> > --
> > 1.6.0.rc1.dirty
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Boyd Gerber <gerberb@zenez.com>
ZENEZ 1042 East Fort Union #135, Midvale Utah 84047
next prev parent reply other threads:[~2008-07-30 20:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-05 17:21 [PATCH] Compile fix for SCO OpenServer Aidan Van Dyk
2008-07-30 18:49 ` Compile fix for SCO OPenServer Aidan Van Dyk
2008-07-30 20:01 ` Junio C Hamano
2008-07-30 20:09 ` Boyd Lynn Gerber [this message]
2008-07-30 20:18 ` Junio C Hamano
2008-07-30 20:43 ` Aidan Van Dyk
2008-07-30 21:28 ` Boyd Lynn Gerber
2008-07-30 22:56 ` Aidan Van Dyk
2008-07-30 23:30 ` Boyd Lynn Gerber
2008-07-30 23:44 ` Aidan Van Dyk
2008-07-31 0:00 ` Boyd Lynn Gerber
2008-07-31 0:11 ` Aidan Van Dyk
2008-07-31 0:32 ` Boyd Lynn Gerber
2008-07-30 20:13 ` Boyd Lynn Gerber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.1.10.0807301403360.13032@xenau.zenez.com \
--to=gerberb@zenez.com \
--cc=aidan@highrise.ca \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).