From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boyd Lynn Gerber Subject: Re: Compile fix for SCO OPenServer Date: Wed, 30 Jul 2008 14:09:03 -0600 Message-ID: References: <20071205172125.GF12636@yugib.highrise.ca> <20080730184956.GF10399@yugib.highrise.ca> <7vtze73zwg.fsf@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Aidan Van Dyk , git@vger.kernel.org To: Junio C Hamano X-From: git-owner@vger.kernel.org Wed Jul 30 22:10:26 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1KOHzx-0006tY-4h for gcvg-git-2@gmane.org; Wed, 30 Jul 2008 22:10:13 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756055AbYG3UJG (ORCPT ); Wed, 30 Jul 2008 16:09:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756046AbYG3UJF (ORCPT ); Wed, 30 Jul 2008 16:09:05 -0400 Received: from zenez.com ([166.70.62.2]:5000 "EHLO xenau.zenez.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754872AbYG3UJF (ORCPT ); Wed, 30 Jul 2008 16:09:05 -0400 Received: by xenau.zenez.com (Postfix, from userid 1000) id E19633F969; Wed, 30 Jul 2008 14:09:03 -0600 (MDT) Received: from localhost (localhost [127.0.0.1]) by xenau.zenez.com (Postfix) with ESMTP id 954B43E7C4; Wed, 30 Jul 2008 14:09:03 -0600 (MDT) In-Reply-To: <7vtze73zwg.fsf@gitster.siamese.dyndns.org> User-Agent: Alpine 1.10 (LNX 962 2008-03-14) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Wed, 30 Jul 2008, Junio C Hamano wrote: > Aidan Van Dyk writes: > > SCO OpenServer also hides the definitions of (at least) u_short and > > friends if _XOPEN_SOURCE is defined. > > I thought that was covered by 457bb45 (Port to 12 other Platforms., 2008-06-08). I thought it was covered as well. > Sign-off? > > Boyd, does this make any of the earlier symbols you added redundant? I have just tried this on 4 OpenServer 6.0 machines fresh installed and I do not need this added. I am trying to figure out what is different on his. It appears he is using the exact same version of the compiler as well. My uname -a gives me this... SCO_SV tech0 5 6.0.0 i386 and the gcc -V gives me the exact same compiler. So I do not know why he has to have the additional __OPENSERVER__. This does break my OpenServer 5.0.7 fresh install as well. So I would not use it. What I do not understand is why the !defined(__USLC__) does not catch it. It should. > > git-compat-util.h | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/git-compat-util.h b/git-compat-util.h > > index cf89cdf..42e3e0b 100644 > > --- a/git-compat-util.h > > +++ b/git-compat-util.h > > @@ -39,7 +39,7 @@ > > /* Approximation of the length of the decimal representation of this type. */ > > #define decimal_length(x) ((int)(sizeof(x) * 2.56 + 0.5) + 1) > > > > -#if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__USLC__) && !defined(_M_UNIX) > > +#if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__USLC__) && !defined(_M_UNIX) && !defined(__OPENSERVER__) > > #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */ > > #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */ > > #endif > > -- > > 1.6.0.rc1.dirty > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Boyd Gerber ZENEZ 1042 East Fort Union #135, Midvale Utah 84047