git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boyd Lynn Gerber <gerberb@zenez.com>
To: Jeff King <peff@peff.net>
Cc: Brandon Casey <casey@nrlssc.navy.mil>,
	Arjen Laarhoven <arjen@yaph.org>,
	git@vger.kernel.org, Mike Ralphson <mike.ralphson@gmail.com>,
	Johannes Sixt <j.sixt@viscovery.net>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [RFC/PATCH] Use compatibility regex library for OSX/Darwin
Date: Tue, 16 Sep 2008 17:42:11 -0600	[thread overview]
Message-ID: <alpine.LNX.1.10.0809161738010.17105@suse104.zenez.com> (raw)
In-Reply-To: <20080916233220.GA14173@coredump.intra.peff.net>

On Tue, 16 Sep 2008, Jeff King wrote:
> On Tue, Sep 16, 2008 at 05:25:46PM -0600, Boyd Lynn Gerber wrote:
>>> I wonder if this is the right fix? Right now the GNU regex library is
>>> necessary for Darwin, FreeBSD and AIX. I can add IRIX6.5 and Solaris 7
>>> to that list. Have newer Solaris's been tested yet? (Jeff?) I wonder if
>>> the new test which triggers this flaw has been tested on the other
>>> non-GNU platforms in the Makefile which have not been updated. Boyd
>>> Lynn Gerber and his 12 platforms comes to mind.
>>
>> Someone forwarded me this email and asked if I had tested it.  I have not.
>> Where is the easiest place to get it to test with the various platforms?
>> I will check it out on 3-5 of them.  I now have 1.6.0.2 on 5 platforms
>> running and working.  I have not had the time to get it on the other's
>> yet.
>
> The problematic test is in 1.6.0.2; if you can run t4018-diff-funcname
> successfully, then I believe you are not affected.

When I do a gmake test these 4 platforms all fail only these 2 tests.

* FAIL 10: reinit


                 (
                         unset GIT_CONFIG GIT_WORK_TREE GIT_CONFIG

                         mkdir again &&
                         cd again &&
                         git init >out1 2>err1 &&
                         git init >out2 2>err2
                 ) &&
                 grep "Initialized empty" again/out1 &&
                 grep "Reinitialized existing" again/out2 &&
                 >again/empty &&
                 test_cmp again/empty again/err1 &&
                 test_cmp again/empty again/err2

* FAIL 11: init with --template

                 mkdir template-source &&
                 echo content >template-source/file &&
                 (
                         mkdir template-custom &&
                         cd template-custom &&
                         git init --template=../template-source
                 ) &&
                 test_cmp template-source/file template-custom/.git/file

*   ok 12: init with --template (blank)
* failed 2 among 12 test(s)
gmake[1]: *** [t0001-init.sh] Error 1
gmake[1]: Leaving directory `/home/zenez/build/osr6/git-1.6.0.2/t'
gmake: *** [test] Error 2

I have not had time to look into the failures.  How many tests should I 
see and pass.  The first 40 all pass.  Then 2 of 12 fail as above.

--
Boyd Gerber <gerberb@zenez.com>
ZENEZ	1042 East Fort Union #135, Midvale Utah  84047

  reply	other threads:[~2008-09-16 23:43 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-07 18:45 [RFC/PATCH] Use compatibility regex library for OSX/Darwin Arjen Laarhoven
2008-09-10  8:03 ` Mike Ralphson
2008-09-10  9:49   ` Johannes Sixt
2008-09-10 10:03   ` Arjen Laarhoven
2008-09-10 11:53     ` Mike Ralphson
2008-09-11  7:59       ` Mike Ralphson
2008-09-11  8:14         ` [PATCH] Use compatibility regex library also on AIX Johannes Sixt
2008-09-11  8:25           ` Arjen Laarhoven
2008-09-11  8:31             ` Mike Ralphson
2008-09-11 12:12               ` Jeff King
2008-09-11  8:27           ` Junio C Hamano
2008-09-16 17:49 ` [RFC/PATCH] Use compatibility regex library for OSX/Darwin Brandon Casey
2008-09-16 18:09   ` Junio C Hamano
2008-09-18  0:08     ` [PATCH 1/4] diff.c: return pattern entry pointer rather than just the hunk header pattern Brandon Casey
2008-09-18  0:10     ` [PATCH 2/4] diff.c: associate a flag with each pattern and use it for compiling regex Brandon Casey
2008-09-18  4:14       ` Junio C Hamano
2008-09-18  6:41         ` Andreas Ericsson
2008-09-18  7:12           ` Junio C Hamano
2008-09-18  8:06             ` Andreas Ericsson
2008-09-18  8:35               ` Junio C Hamano
2008-09-18  0:10     ` [PATCH 3/4] diff.*.xfuncname which uses "extended" regex's for hunk header selection Brandon Casey
     [not found]       ` <7vd4j212gb.fsf@gitster.siamese.dyndns.org>
2008-09-19 18:14         ` Brandon Casey
2008-09-18  0:21     ` [PATCH 4/4] diff.c: convert builtin funcname patterns to extended regular expressions Brandon Casey
2008-09-18  0:33       ` [PATCH 4/4 v2] " Brandon Casey
2008-09-18  7:18       ` [PATCH 4/4] " Andreas Ericsson
2008-09-18  7:31         ` Junio C Hamano
2008-09-18  8:39       ` Johan Herland
2008-09-18 10:15         ` Gustaf Hendeby
2008-09-18 10:53       ` Jonathan del Strother
2008-09-18 15:48         ` Brandon Casey
2008-09-16 19:08   ` [RFC/PATCH] Use compatibility regex library for OSX/Darwin Jeff King
2008-09-16 23:25   ` Boyd Lynn Gerber
2008-09-16 23:32     ` Jeff King
2008-09-16 23:42       ` Boyd Lynn Gerber [this message]
2008-09-16 23:46         ` Jeff King
2008-09-17  0:10           ` Boyd Lynn Gerber
2008-09-17  0:13             ` Brandon Casey
2008-09-17  0:13           ` Boyd Lynn Gerber
2008-09-17  0:20             ` Brandon Casey
2008-09-17  0:38               ` Boyd Lynn Gerber
2008-09-17  0:58                 ` Brandon Casey
2008-09-17  1:02           ` Boyd Lynn Gerber
2008-09-17  1:25             ` Brandon Casey
2008-09-17 14:48               ` Boyd Lynn Gerber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.1.10.0809161738010.17105@suse104.zenez.com \
    --to=gerberb@zenez.com \
    --cc=arjen@yaph.org \
    --cc=casey@nrlssc.navy.mil \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j.sixt@viscovery.net \
    --cc=mike.ralphson@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).