Re: [PATCH 2/2] Implement git-vcs-p4

[Daniel Barkalow <barkalow@iabervon.org>]

On Wed, 5 Aug 2009, Junio C Hamano wrote:

> Daniel Barkalow <barkalow@iabervon.org> writes:
> 
> > This is probably not particularly appropriate for mainline
> > application, and is somewhat buggy, not extensively tested, and
> > incomplete, but is here as an example implementation of the API and in
> > case it is useful to other people.
> 
> I do not mind carrying this in the tree, at least on 'pu', for wider
> exposure---giving easier access to others _might_ help you gain
> contributors.
> 
> But we need to disable this in the Makefile by default and force
> interested parties to explicitly ask for it if we were to do that.

There are two ways it can be built: either against the API library that 
Perforce distributes (without any obvious license documents) or to call 
the client executable. The Makefile only tries to build against the API if 
configured to have the location of it; it currently tries the client if 
the API wasn't configured, but I'll make it only try even that if 
configured to do so.

Alternatively, perhaps I should set up the Makefile to have a 
configuration option for contrib subdirectories that need to be built? I 
didn't put it in contrib/ because it (currently) needs to link against 
-lgit, depend on it, and have compilation rules, and everything currently 
in contrib/ is interpreted code.

	-Daniel
*This .sig left intentionally blank*