From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Barkalow Subject: Re: [PATCH not-for-mainline] Implement git-vcs-p4 Date: Wed, 27 Jan 2010 11:49:02 -0500 (EST) Message-ID: References: <1a6be5fa1001270318h4ac8ac3bnaba48787a5b3efa6@mail.gmail.com> <20100127155636.GA18210@Knoppix> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Tor Arvid Lund , git@vger.kernel.org To: Ilari Liusvaara X-From: git-owner@vger.kernel.org Wed Jan 27 17:49:17 2010 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NaB4t-0002sX-0e for gcvg-git-2@lo.gmane.org; Wed, 27 Jan 2010 17:49:15 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754777Ab0A0QtJ (ORCPT ); Wed, 27 Jan 2010 11:49:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754062Ab0A0QtJ (ORCPT ); Wed, 27 Jan 2010 11:49:09 -0500 Received: from iabervon.org ([66.92.72.58]:45841 "EHLO iabervon.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752806Ab0A0QtG (ORCPT ); Wed, 27 Jan 2010 11:49:06 -0500 Received: (qmail 5571 invoked by uid 1000); 27 Jan 2010 16:49:02 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 27 Jan 2010 16:49:02 -0000 In-Reply-To: <20100127155636.GA18210@Knoppix> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Wed, 27 Jan 2010, Ilari Liusvaara wrote: > On Wed, Jan 27, 2010 at 12:18:35PM +0100, Tor Arvid Lund wrote: > > > Then, I did 'git fetch', and got a seg fault. I got around it by > > commenting out a line: > > > > diff --git a/transport.c b/transport.c > > index 7714fdb..5b404f7 100644 > > --- a/transport.c > > +++ b/transport.c > > @@ -924,7 +924,7 @@ struct transport *transport_get(struct remote > > *remote, const char *url) > > ret->url = url; > > > > /* In case previous URL had helper forced, reset it. */ > > - remote->foreign_vcs = NULL; > > +/* remote->foreign_vcs = NULL;*/ > > > > /* maybe it is a foreign URL? */ > > if (url) { > > > > Hmm... And just commenting out that line will break case if you have > push URL using remote helpers and second one for same remote that > doesn't. > > I'll look into that issue. I think that field should only be used for things like: [remote "foo"] vcs = something ... and the case where the helper is inferred from the URL shouldn't use a field on the remote, but be passing the information around in function arguments. A field of the struct remote only really makes sense with information that applies to the whole remote. -Daniel *This .sig left intentionally blank*