From mboxrd@z Thu Jan  1 00:00:00 1970
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: I don't want the .git directory next to my code.
Date: Thu, 17 Jan 2008 18:10:31 +0000 (GMT)
Message-ID: <alpine.LSU.1.00.0801171809400.5731@racer.site>
References: <478D79BD.7060006@talkingspider.com> <86hcheig3n.fsf@blue.stonehenge.com> <478D82FA.2030404@talkingspider.com> <478D95D8.5040806@theory.org> <478E3D8E.1090300@talkingspider.com> <alpine.LFD.1.00.0801161000310.2806@woody.linux-foundation.org>
 <alpine.LFD.1.00.0801161019250.2806@woody.linux-foundation.org> <478EEAC4.2010006@talkingspider.com> <20080117151725.GC2816@coredump.intra.peff.net> <alpine.LFD.1.00.0801170849070.14959@woody.linux-foundation.org> <alpine.LSU.1.00.0801171748520.5731@racer.site>
 <alpine.LFD.1.00.0801170958550.14959@woody.linux-foundation.org>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>,
	Mike <fromlists@talkingspider.com>,
	Git Mailing List <git@vger.kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
X-From: git-owner@vger.kernel.org Thu Jan 17 19:11:05 2008
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1JFZCi-0007ED-VC
	for gcvg-git-2@gmane.org; Thu, 17 Jan 2008 19:11:05 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752086AbYAQSKg (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Thu, 17 Jan 2008 13:10:36 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752078AbYAQSKg
	(ORCPT <rfc822;git-outgoing>); Thu, 17 Jan 2008 13:10:36 -0500
Received: from mail.gmx.net ([213.165.64.20]:56394 "HELO mail.gmx.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP
	id S1751803AbYAQSKg (ORCPT <rfc822;git@vger.kernel.org>);
	Thu, 17 Jan 2008 13:10:36 -0500
Received: (qmail invoked by alias); 17 Jan 2008 18:10:34 -0000
Received: from unknown (EHLO [138.251.11.74]) [138.251.11.74]
  by mail.gmx.net (mp057) with SMTP; 17 Jan 2008 19:10:34 +0100
X-Authenticated: #1490710
X-Provags-ID: V01U2FsdGVkX19pp0MzQTRp8y7dCsqP95sowk6aypZ6YrdQR6v2Pa
	p9xGpM2q5YhzCe
X-X-Sender: gene099@racer.site
In-Reply-To: <alpine.LFD.1.00.0801170958550.14959@woody.linux-foundation.org>
User-Agent: Alpine 1.00 (LSU 882 2007-12-20)
X-Y-GMX-Trusted: 0
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/70888>

Hi,

On Thu, 17 Jan 2008, Linus Torvalds wrote:

> On Thu, 17 Jan 2008, Johannes Schindelin wrote:
> >
> > > Ok, here's the ugliest idea *ever*:
> > 
> > Okay, you won.
> 
> "I would like to thank the Academy for giving me this honor. I couldn't
>  have done this without my parents, my teachers in high school, and the 
>  girl next-door.."

You forgot the tears.

> > > +		attr_len = getxattr(".", "user.git-dir", git_dir, sizeof(git_dir)-1);
> > > +		if (attr_len > 0) {
> > > +			git_dir[attr_len] = 0;
> > > +			if (is_git_directory(git_dir)) {
> > > +				setenv(GIT_DIR_ENVIRONMENT, git_dir, 1);
> > > +				break;
> > 
> > What's this break all about?
> 
> Without the break, it will consider it a failure, and try to go up the 
> directory structure ("..") to find the next thing.

Ah, but of course.  For some reason I expected this code outside of the 
loop, but it _has_ to be inside.

Thanks for enlightening a poor schmock,
Dscho