From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Schindelin Subject: Re: [PATCH 2/2] Clean up connection correctly if object fetch wasn't done Date: Mon, 4 Feb 2008 21:21:39 +0000 (GMT) Message-ID: References: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Junio C Hamano , git@vger.kernel.org To: Daniel Barkalow X-From: git-owner@vger.kernel.org Mon Feb 04 22:22:54 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1JM8mD-000852-82 for gcvg-git-2@gmane.org; Mon, 04 Feb 2008 22:22:53 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754035AbYBDVWS (ORCPT ); Mon, 4 Feb 2008 16:22:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753942AbYBDVWS (ORCPT ); Mon, 4 Feb 2008 16:22:18 -0500 Received: from mail.gmx.net ([213.165.64.20]:45619 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754032AbYBDVWR (ORCPT ); Mon, 4 Feb 2008 16:22:17 -0500 Received: (qmail invoked by alias); 04 Feb 2008 21:22:15 -0000 Received: from unknown (EHLO [138.251.11.74]) [138.251.11.74] by mail.gmx.net (mp014) with SMTP; 04 Feb 2008 22:22:15 +0100 X-Authenticated: #1490710 X-Provags-ID: V01U2FsdGVkX19b2ahF0jpbUff1lNmaKDwqzOouzPwIlfNApA6178 MmoG+/k4V/DdrQ X-X-Sender: gene099@racer.site In-Reply-To: User-Agent: Alpine 1.00 (LSU 882 2007-12-20) X-Y-GMX-Trusted: 0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Hi, On Mon, 4 Feb 2008, Daniel Barkalow wrote: > On Mon, 4 Feb 2008, Johannes Schindelin wrote: > > > On Mon, 4 Feb 2008, Daniel Barkalow wrote: > > > > > Further optimization allowed the fetch_objs call to be skipped if it > > > isn't necessary. However, this leaves the connection in need of > > > cleaning up to avoid getting an error message from the remote end > > > when ssh is used. Fix this. > > > > I _think_ something similar is necessary for ls-remote, too (at least > > it showed the same symptoms today, but I have not had time to > > investigate yet). > > Yup, exactly the same change to builtin-ls-remote that builtin-fetch > needed. Thanks, works here. Ciao, Dscho