From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH 5/9] Add "skip_unmerged" option to unpack_trees.
Date: Tue, 5 Feb 2008 01:32:08 +0000 (GMT) [thread overview]
Message-ID: <alpine.LSU.1.00.0802050129570.8543@racer.site> (raw)
In-Reply-To: <alpine.LNX.1.00.0802041335530.13593@iabervon.org>
Hi,
On Mon, 4 Feb 2008, Daniel Barkalow wrote:
> if (any_files) {
> - if (o->merge) {
> + if (skip_entry) {
> + do
> + o->pos++;
> + while (o->pos < active_nr &&
> + !strcmp(active_cache[o->pos]->name,
> + src[0]->name));
> + } else if (o->merge) {
Maybe it is just me, but I would have thought
while (++o->pos < active_nr)
if (strcmp(active_cache[o->pos]->name,
src[0]->name))
break;
more readable. But that's maybe because I have trouble with do ... while
constructs logically (I like to see the loop condition first, then the
loop body).
Ciao,
Dscho
next prev parent reply other threads:[~2008-02-05 1:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-04 18:35 [PATCH 5/9] Add "skip_unmerged" option to unpack_trees Daniel Barkalow
2008-02-05 1:32 ` Johannes Schindelin [this message]
2008-02-05 20:38 ` Daniel Barkalow
2008-02-05 22:50 ` Johannes Schindelin
2008-02-05 23:44 ` Junio C Hamano
2008-02-06 1:05 ` Daniel Barkalow
-- strict thread matches above, loose matches on Subject: below --
2008-01-25 23:24 Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.1.00.0802050129570.8543@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox